From owner-svn-ports-head@FreeBSD.ORG Fri Apr 5 12:38:46 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 6314C19E; Fri, 5 Apr 2013 12:38:46 +0000 (UTC) (envelope-from makc@freebsd.org) Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3]) by mx1.freebsd.org (Postfix) with ESMTP id C6CE935D; Fri, 5 Apr 2013 12:38:45 +0000 (UTC) Received: from mercury.ph.man.ac.uk [130.88.75.175:49800] (HELO/EHLO mercury.ph.man.ac.uk, authenticated with LOGIN) by mail.issp.ac.ru with ESMTP/inet id r35Ccuct041439 (using TLSv1/SSLv3, with cipher DHE-RSA-AES256-SHA (256 bits), verified NO) Fri, 5 Apr 2013 16:38:57 +0400 (MSK) From: Max Brazhnikov To: Sunpoet Po-Chuan Hsieh Subject: Re: svn commit: r315222 - in head: devel/qdevelop games/warmux graphics/xaos math/qtiplot multimedia/minitube print/hplip textproc/qstardict Date: Fri, 05 Apr 2013 12:40:07 +0000 Message-ID: <33299091.KSdYOtgceu@mercury.ph.man.ac.uk> User-Agent: KMail/4.10.1 (FreeBSD/9.1-STABLE; KDE/4.10.1; amd64; ; ) In-Reply-To: References: <201303251359.r2PDxIXf035701@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="ISO-8859-1" Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , Eitan Adler , svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2013 12:38:46 -0000 On Thu, 04 Apr 2013 17:24:32 +0800 Sunpoet Po-Chuan Hsieh wrote: > I think these options can be used globally and also per port. These options > are just on by default via bsd.options.mk. Users should be able to turn > them off through options dialog while building/installing specific port. I > think it has higher possibility that one user wants to install > documentation/examples of *some ports but not all ports*. As a result, we > should keep those options. At least we shall not always hide them. > > If maintainers think these options are annoying, they could put them to the > end of OPTIONS_DEFINE. We don't disagree about DOCS/NSL/etc options, when a ports already defines other options. The question is should these options be in OPTIONS_DEFINE if they are the only options provided by the port (read: allow option dialog to pop up with trivial option set for virtually every port)? Max > On Thu, Mar 28, 2013 at 10:57 AM, Eitan Adler wrote: > > > On 27 March 2013 22:53, Alexey Dokuchaev wrote: > > > On Mon, Mar 25, 2013 at 01:59:18PM +0000, Max Brazhnikov wrote: > > >> New Revision: 315222 > > >> URL: http://svnweb.freebsd.org/changeset/ports/315222 > > >> > > >> - Remove OPTIONS_DEFINE, if it contains only global options > > > > > > Can you elaborate on this one? Given that there is no clear policy, > > > personally I've been always including OPTIONS_DEFINE, even if just for, > > say, > > > DOCS. > > > > Options such as IPV6, DOCS, EXAMPLES, and NLS are generally set > > globally (e.g., OPTIONS_UNSET= NLS) and not per port. As such, it can > > reduce user annoyance if the dialog box is not shown for such options. > > > > > > > > -- > > Eitan Adler > > Source, Ports, Doc committer > > Bugmeister, Ports Security teams > >