Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Jan 2024 13:26:55 +0100
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Gleb Popov <arrowd@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: c841c52f8c28 - main - x11/sfwbar: Install mans to share and sort plist.
Message-ID:  <jzoe-n3e8-wny@FreeBSD.org>
In-Reply-To: <202401121141.40CBf5jY067089@gitrepo.freebsd.org> (Gleb Popov's message of "Fri, 12 Jan 2024 11:41:05 GMT")
References:  <202401121141.40CBf5jY067089@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Gleb Popov <arrowd@FreeBSD.org> writes:

>    x11/sfwbar: Install mans to share and sort plist.

Mixing style and functional changes makes pkg-plist diff hard to read.
See also https://docs.freebsd.org/en/articles/committers-guide/#_other_suggestions

> -MESON_ARGS=		-Dbsdctl=enabled -Dnetwork=enabled -Dbluez=enabled -Didleinhibit=enabled -Diwd=enabled
> +MESON_ARGS=		-Dbsdctl=enabled -Dnetwork=enabled -Dbluez=enabled \
> +			-Didleinhibit=enabled -Diwd=enabled --mandir=share/man

Why not fix USES=meson itself?

diff --git a/Mk/Uses/meson.mk b/Mk/Uses/meson.mk
index ae997ae1a337..3a6ae041ff97 100644
--- a/Mk/Uses/meson.mk
+++ b/Mk/Uses/meson.mk
@@ -33,7 +33,7 @@ BUILD_DEPENDS+=		meson:devel/meson
 USE_LOCALE?=	en_US.UTF-8
 
 CONFIGURE_ARGS+=	--prefix ${PREFIX} \
-			--mandir man \
+			--mandir share/man \
 			--infodir ${INFO_PATH}
 
 # Enable all optional features to make builds deterministic. Consumers can



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?jzoe-n3e8-wny>