From owner-svn-src-head@freebsd.org Tue Nov 21 05:50:27 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 747B8DE2CF1 for ; Tue, 21 Nov 2017 05:50:27 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3AA198091E for ; Tue, 21 Nov 2017 05:50:27 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22f.google.com with SMTP id u42so18191995ioi.9 for ; Mon, 20 Nov 2017 21:50:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=bCwmJ5+dVKANx9tYfhOxVea27Mlqa89CbkFrif9k7vE=; b=pDdIWgpIGbidHdoqyYIclUjlM7bVOf3lnOJ3x/SbPblztjPJR+/7tH9Jn61CBdCMyX 6IKpg59luE5rHJvQuf0hgICrdp/DKUD/eyvO33VWK1Df7hRUQflTp2QTp7KVLD8D7uMh vDgwETZ7swPMWQUuCcqSizUPdJKKwLdQJb0upoUAur4iTL7CmutcwBoCyEPjnWd3OgxP Xu3Up0QU00G/UaxTqCvY3yIFi/DcpCeSMqbeON4LdxQ+jX0rnzepdi9SHT6pl/7yC2zF i3Lko7hV8xKC0WsO1UjfZyMG80GpkU3zjMp0Y87V981WectEcYbkGHYMl1MSzOlfBk1P WR4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=bCwmJ5+dVKANx9tYfhOxVea27Mlqa89CbkFrif9k7vE=; b=F9aAEWvWXROzP19b1CkvwoRllM24iKHSu8RglQTdkabYq+aFoDfwZxr5xvGniXzhOF j5a14iUtYVOb2kiWnvoyVVlLDl0YTrT1udJb7tTvXcysKdlqoSJ8g/TVWpWHGFbO41Ku d/zdQm83Xyubl5tYMZjLlYhq9RunVt++CvTf9OfzIX3djTgXManGV+8WeVo23Dc9kxGN 3mgwRXIYBOVKqH9Rz5dKCXoqC4uSQUuVDHFXo0Xb9ssaAKS8eBJPgNNZy2m5A/Ny3ZhV REMgH5xabEaxM1MN2lL5xtWUP0K0W19VYGwWgi/fxJxBqTe8M1i9dAVnN/cCGnvtFZTU zR1g== X-Gm-Message-State: AJaThX7sl2zBVZ3FpD3SQx+nxQYtwlbBPUmxS7gC1ywcA6h5ht/7jTn4 8ZhDkcyC6L7n+zUoEGhxDo3fPH3w6KK0UA1CDEzfrw== X-Google-Smtp-Source: AGs4zMYUMirf2rHA9HHrwsX+9yvnmjzdyh0ROV80FSVy6f9d9MWPkAjH1uC/C3Z47SA9sp5nhBnOHLZhaTtbjqD6Fyg= X-Received: by 10.107.48.197 with SMTP id w188mr14056250iow.301.1511243426487; Mon, 20 Nov 2017 21:50:26 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Mon, 20 Nov 2017 21:50:25 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:c91c:5e34:ef38:d5a] In-Reply-To: <2434FC04-1FF3-48B0-8743-78412673616F@dsl-only.net> References: <2434FC04-1FF3-48B0-8743-78412673616F@dsl-only.net> From: Warner Losh Date: Mon, 20 Nov 2017 22:50:25 -0700 X-Google-Sender-Auth: iTfnd3j5q87oMInuN6Djqo7cLlI Message-ID: Subject: Re: svn commit: r326038 - in head/stand: . arm/uboot efi efi/fdt fdt i386 mips/beri mips/beri/boot2 mips/beri/loader mips/uboot ofw/libofw powerpc/boot1.chrp powerpc/kboot powerpc/ofw powerpc/ps3 power... To: Mark Millard Cc: Warner Losh , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 05:50:27 -0000 On Mon, Nov 20, 2017 at 10:30 PM, Mark Millard wrote: > It looks to me like head/stand/powerpc/boot1.chrp/Makefile might > have += vs. = issues compared to the other examples: > > Warner Losh imp at FreeBSD.org wrote on > Mon Nov 20 22:42:21 UTC 2017 : > > Modified: head/stand/powerpc/boot1.chrp/Makefile > ============================================================ > ================== > --- head/stand/powerpc/boot1.chrp/Makefile Mon Nov 20 22:41:22 2017 > (r326037) > +++ head/stand/powerpc/boot1.chrp/Makefile Mon Nov 20 22:42:17 2017 > (r326038) > @@ -13,9 +13,7 @@ SRCS= boot1.c ashldi3.c syncicache.c > > MAN= > > -CFLAGS= -ffreestanding -msoft-float \ > - -I${LDRSRC} -I${SYSDIR} -I${SASRC} \ > - -D_STANDALONE > +CFLAGS= -I${LDRSRC} -I${SYSDIR} -I${SASRC} -D_STANDALONE > LDFLAGS=-nostdlib -static -Wl,-N > > .PATH: ${SYSDIR}/libkern ${SRCTOP}/lib/libc/powerpc/gen ${.CURDIR} > > but the other files tend to use += for at least CFLAGS. In > one case you converted an = into only using += locally: > > -CFLAGS= -ffreestanding \ > - -I${.CURDIR} \ > +CFLAGS+= -I${.CURDIR} \ > > (Generally the mix seems to be as it was before > the changes but it likely looked odd before the > changes when the files were view together.) > > There are also examples like: > > LDFLAGS= -nostdlib -static -T ${.CURDIR}/ldscript.${MACHINE_ > CPUARCH} > LDFLAGS+= -Wl,-znotext > > and others with just = . But some files seem to always > use += for LDFLAGS. > > May be a round of = vs. += checking is appropriate > for the involved files? > Yea. I've done it once or twice already. It's quite likely another pass may be necessary, so it doesn't surprise me you've found at least one places that needs a good close look... There's a few places LDFLAGS are used, and it seems everywhere it has -nostdlib, and maybe a few others. And there's likely a few places where some of the defines need to be moved around to. Warner