From owner-svn-src-all@FreeBSD.ORG Mon Dec 28 21:54:01 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB7551065672; Mon, 28 Dec 2009 21:54:01 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id DDA098FC1C; Mon, 28 Dec 2009 21:54:00 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id A5AB573098; Mon, 28 Dec 2009 23:01:44 +0100 (CET) Date: Mon, 28 Dec 2009 23:01:44 +0100 From: Luigi Rizzo To: "Bjoern A. Zeeb" Message-ID: <20091228220144.GA38493@onelab2.iet.unipi.it> References: <200912282114.nBSLEJVj001562@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200912282114.nBSLEJVj001562@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r201141 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2009 21:54:02 -0000 On Mon, Dec 28, 2009 at 09:14:19PM +0000, Bjoern A. Zeeb wrote: > Author: bz > Date: Mon Dec 28 21:14:18 2009 > New Revision: 201141 > URL: http://svn.freebsd.org/changeset/base/201141 > > Log: > Make the compiler happy after r201125: > - + remove two unnecessary initializations in ip_output; > + + remove one unnecessary initializations in ip_output; does it give a warning or an error ? I tried a buildkernel (i386) and also a picobsd build and neither give any warning. cheers luigi > Modified: > head/sys/netinet/ip_output.c > > Modified: head/sys/netinet/ip_output.c > ============================================================================== > --- head/sys/netinet/ip_output.c Mon Dec 28 20:54:34 2009 (r201140) > +++ head/sys/netinet/ip_output.c Mon Dec 28 21:14:18 2009 (r201141) > @@ -113,7 +113,7 @@ ip_output(struct mbuf *m, struct mbuf *o > struct ip_moptions *imo, struct inpcb *inp) > { > struct ip *ip; > - struct ifnet *ifp; > + struct ifnet *ifp = NULL; /* keep compiler happy */ > struct mbuf *m0; > int hlen = sizeof (struct ip); > int mtu;