From owner-freebsd-arch@FreeBSD.ORG Thu Aug 7 23:06:43 2008 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A7E841065675; Thu, 7 Aug 2008 23:06:43 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 53BE28FC15; Thu, 7 Aug 2008 23:06:43 +0000 (UTC) (envelope-from des@des.no) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id 62431207E; Fri, 8 Aug 2008 01:06:42 +0200 (CEST) Received: by ds4.des.no (Postfix, from userid 1001) id 39E2184497; Fri, 8 Aug 2008 01:06:42 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Oleksandr Tymoshenko References: <20080729.161303.709402272.imp@bsdimp.com> <86r69buar0.fsf@ds4.des.no> <489B08F6.8060605@freebsd.org> Date: Fri, 08 Aug 2008 01:06:42 +0200 In-Reply-To: <489B08F6.8060605@freebsd.org> (Oleksandr Tymoshenko's message of "Thu, 07 Aug 2008 17:38:46 +0300") Message-ID: <867iasfmrh.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: kan@freebsd.org, arch@freebsd.org, pjd@freebsd.org Subject: Re: Need a code review X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Aug 2008 23:06:43 -0000 Oleksandr Tymoshenko writes: > openpam detects static modules build using cpp(1) condition: > #if defined(__GNUC__) && !defined(__PIC__) && !defined(NO_STATIC_MODULES) > The problem is that gcc MIPS option -mabi-calls assumes -fpic for both > static and dynamic builds. So the question is: would defining > NO_STATIC_MODULES for MIPS be enough or it should be addressed > upstream? "upstream" in this case means me. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no