From owner-freebsd-python@freebsd.org Thu Jan 21 05:38:38 2021 Return-Path: Delivered-To: freebsd-python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D296C4EA9C8 for ; Thu, 21 Jan 2021 05:38:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DLrly5RyGz4vLZ for ; Thu, 21 Jan 2021 05:38:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B8B344EABEA; Thu, 21 Jan 2021 05:38:38 +0000 (UTC) Delivered-To: python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B87C44EAE95 for ; Thu, 21 Jan 2021 05:38:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DLrly4jjFz4vcF for ; Thu, 21 Jan 2021 05:38:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 94E7926854 for ; Thu, 21 Jan 2021 05:38:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 10L5cc62067704 for ; Thu, 21 Jan 2021 05:38:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 10L5ccux067703 for python@FreeBSD.org; Thu, 21 Jan 2021 05:38:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: maintainer-feedback requested: [Bug 252875] devel/ipython: completion still broken after 7.19.0_2 Date: Thu, 21 Jan 2021 05:38:38 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2021 05:38:38 -0000 Bugzilla Automation has asked freebsd-python (Nobody) for maintainer-feedback: Bug 252875: devel/ipython: completion still broken after 7.19.0_2 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252875 --- Description --- The patch to 7.19.0_2 exposed some other problems: File "/usr/local/lib/python3.9/site-packages/prompt_toolkit/completion/base.py", line 196, in get_completions_async for item in self.get_completions(document, complete_event): File "/usr/local/lib/python3.9/site-packages/IPython/terminal/ptutils.py", line 116, in get_completions exc_type, exc_value, exc_tb =3D sys.exc_info() NameError: name 'sys' is not defined It turns out that ptutils.py needs two additional imports: import sys import traceback (see attached patch) This however exposes another bug: Traceback (most recent call last): File "/usr/local/lib/python3.9/site-packages/IPython/terminal/ptutils.py", line 115, in get_completions yield from self._get_completions(body, offset, cursor_position, self.ipy_completer) File "/usr/local/lib/python3.9/site-packages/IPython/terminal/ptutils.py", line 131, in _get_completions for c in completions: File "/usr/local/lib/python3.9/site-packages/IPython/core/completer.py", = line 438, in _deduplicate_completions completions =3D list(completions) File "/usr/local/lib/python3.9/site-packages/IPython/core/completer.py", = line 1817, in completions for c in self._completions(text, offset, _timeout=3Dself.jedi_compute_type_timeout/1000): File "/usr/local/lib/python3.9/site-packages/IPython/core/completer.py", = line 1874, in _completions signature =3D _make_signature(jm) File "/usr/local/lib/python3.9/site-packages/IPython/core/completer.py", = line 991, in _make_signature return '(%s)'% ', '.join([f for f in (_formatparamchildren(p) for p in completion.params) if f]) AttributeError: 'Completion' object has no attribute 'params' Looking at the differences between completer.py in this version and the one= on github HEAD, they are significant. It seems to me that until a new version of IPython is released, py-parso and py-jedi should be rolled back as proposed in #252395.