From owner-cvs-src@FreeBSD.ORG Thu May 3 03:31:12 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3097A16A409 for ; Thu, 3 May 2007 03:31:12 +0000 (UTC) (envelope-from grafan@gmail.com) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.177]) by mx1.freebsd.org (Postfix) with ESMTP id E3A2F13C484 for ; Thu, 3 May 2007 03:31:11 +0000 (UTC) (envelope-from grafan@gmail.com) Received: by py-out-1112.google.com with SMTP id f31so289917pyh for ; Wed, 02 May 2007 20:31:11 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=r5DPSNK/QSzpQxwNRLB8W2IcSq7H9AkcI0xI3g9fPqWprMdNG0pE+AsqqSS8j5JiDiSFijwIyEmdJOj+Rm4QlMe9j4K48RpMrUVkmLSA7wCRtsOeRgBZXH8aZyuSstWjxxPRAhOYzjLmbJTOTtDPXJxxHTCCH7A/BLTXyG2wC18= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=k+cBOlzhPZ5StNJ8K1QFQwq2a6UdaNWHGmG5MjWPrFC8fuB+nHvJIdvjWKtWXTpXzJhndfBTlNlrC4jczohd6CDD/BVFngwl3/pm1+gW6GHW0A20gQPoBxw7p9WfiHws0QHX5lVYVrJMX7u7oj8gSD2eLkXf3bGwYTGF6AnVT74= Received: by 10.64.10.2 with SMTP id 2mr2543586qbj.1178163070956; Wed, 02 May 2007 20:31:10 -0700 (PDT) Received: by 10.64.196.16 with HTTP; Wed, 2 May 2007 20:31:10 -0700 (PDT) Message-ID: <6eb82e0705022031g3b959688k5fb63b6e441a6d86@mail.gmail.com> Date: Thu, 3 May 2007 11:31:10 +0800 From: "Rong-en Fan" To: "Colin Percival" , kientzle@freebsd.org, portmgr@freebsd.org In-Reply-To: <200703151011.l2FABc9Z013002@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200703151011.l2FABc9Z013002@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 03:31:12 -0000 On 3/15/07, Colin Percival wrote: > cperciva 2007-03-15 10:11:38 UTC > > FreeBSD src repository > > Modified files: > usr.bin/tar write.c > Log: > Don't consider an lstat(2) failure to be an error (in the sense of > affecting the return value from bsdtar), since (a) it usually occurs > due to a perfectly innocent (and unavoidable) race condition where a > user deletes a file in the window between bsdtar reading a directory > and attempting to read the file; and (b) aside from printing a warning > message, bsdtar behaves exactly as if the file had been deleted prior > to bsdtar reading its parent directory. This commit makes 'make package' successfully even if the plist is wrong, i.e. it contains ``ghost'' files. Basically, $ tar zcvf a.tgz /aaa tar: /aaa: Cannot stat: No such file or directory It returns 0, so make package will be considered successful. That's why I only get chinese/CJK build failure on 5.x (this is merged to 6.x). I'm CC'ing kientzle@ and portmgr@ (since it affects our package building). Regards, Rong-En Fan. > > Reviewed by: kientzle > MFC after: 6 days > > Revision Changes Path > 1.57 +0 -1 src/usr.bin/tar/write.c > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" >