From owner-cvs-all Mon Apr 29 15:12:20 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.chesapeake.net (chesapeake.net [205.130.220.14]) by hub.freebsd.org (Postfix) with ESMTP id A3EA037B41B; Mon, 29 Apr 2002 15:09:44 -0700 (PDT) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id g3TM9g167537; Mon, 29 Apr 2002 18:09:42 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Mon, 29 Apr 2002 18:09:42 -0400 (EDT) From: Jeff Roberson To: Robert Watson Cc: Alfred Perlstein , , Subject: Re: cvs commit: src/sys/kern kern_malloc.c In-Reply-To: Message-ID: <20020429180632.K18391-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 29 Apr 2002, Robert Watson wrote: > > On Mon, 29 Apr 2002, Alfred Perlstein wrote: > > > > :( > > > > What's with the decimal powers of two here? This should be using a > > shift to avoid this sort of problem. > > Well, I was just restoring the file to its previous state, so I adopted > the same formatting that was there previously. The ommission was a > copy/paste issue from my local tree -- it didn't affect correctness, just > wastage by bumping you to the next bucket. > > Robert N M Watson FreeBSD Core Team, TrustedBSD Project > robert@fledge.watson.org NAI Labs, Safeport Network Services > > It was done on purpose. These should not stay powers of two. There is a comment about this above the code. I didn't want to imply any sort of relationship between powers of two and the bucket sizes. If they were off at all it wouldn't matter anyway. Jeff To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message