From owner-svn-src-all@freebsd.org Mon Jan 22 19:29:42 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15D02ED16BC for ; Mon, 22 Jan 2018 19:29:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C40286A690 for ; Mon, 22 Jan 2018 19:29:41 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x234.google.com with SMTP id d13so6058751iog.5 for ; Mon, 22 Jan 2018 11:29:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=AUZAiSbms4OOeAkMxsuc7Fib+YVY0+SjYBrlHV1S05s=; b=EvSN6r59XIM9nfEVOjypv8Hj7AVbgPqvITYU6G+80dDKCRKvyM4pw/UaN2JGH2ZBov fNhNrMcpfzaMekBRzzdlkeYpyHd9iY8rZqaJyI/Xeavodn6lu/Sy5Hk6THQR9OMVb8gW PH36SOQrt0cEOC6nH7Fz2md0hDhGzZ2NgEfpFsmpbZwVk0utEV5E5CVEMxxKErVj2r1X B/fv83PGmcb30VeF+YgxEabK0dCYCQM/q0GxhfaWVW/HeN7he6JhP1lUa9NLpi/EIEGZ hP8gu6WfKxgWuTy/9OwZtHHzFazqi67dpju7xJKXM44OpR6pK6wJ4h+i+uMWjYndtXSM WzqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=AUZAiSbms4OOeAkMxsuc7Fib+YVY0+SjYBrlHV1S05s=; b=oyUVlutk1DtzhOodLB0U6fz/MYRWYnMs9MZ6tWmpytE5jy5TY02CylPoBUH2KTgm7O 5WcyCrbrOElgETsVx/WNtg2+jCLkXemddWRzgWcm9peuZV1frrZL2GvLjO/jJjcdgT2h rVmW70IgvhEixCkfxeoofcH4Od/E4CKadD4N+KznTQZ4RyVH32o80AI/LOYRK9jytum4 b5NuuTaLpWa+dc685uLGuhEQCJLY5SnpvIeawkB26tIlbjMfD82Kg5ntimmOW+ItrXfs zEGfhAIJZZjooCi/jQuux5Nn1nbQdw8eobALNuAJjRfmBabUvM1QfB2WXxXDDALFWJgE rqhQ== X-Gm-Message-State: AKwxytefhlQkzFpm3UQ6On7LZW5/qnvjGsPKVODwAFvf72MR46s6enIK PFI56WxK9gFRsaKeEqBA9ghNrl4B8Yx1hRTm7mgMyg== X-Google-Smtp-Source: AH8x226NN6rclRcVHzS0zgCAeq1kbBR8eNdKx/8MPX/mvnmMWlnOfmzpvzqMhRbk1cWORcOdlB/Ysr2MmknE7qQKSfo= X-Received: by 10.107.88.12 with SMTP id m12mr8848678iob.136.1516649380973; Mon, 22 Jan 2018 11:29:40 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Mon, 22 Jan 2018 11:29:40 -0800 (PST) X-Originating-IP: [50.227.106.226] In-Reply-To: <89102.1516649067@critter.freebsd.dk> References: <201801220710.w0M7AUm9091853@repo.freebsd.org> <88258.1516630050@critter.freebsd.dk> <20180122153003.664e1613bbf70ab49c5c1541@bidouilliste.com> <52374125.OgxafgljNu@ralph.baldwin.cx> <89102.1516649067@critter.freebsd.dk> From: Warner Losh Date: Mon, 22 Jan 2018 12:29:40 -0700 X-Google-Sender-Auth: fpk2Y6_B9G-O4zPYtIuH6PAR8Jg Message-ID: Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules To: Poul-Henning Kamp Cc: John Baldwin , Emmanuel Vadot , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 19:29:42 -0000 On Mon, Jan 22, 2018 at 12:24 PM, Poul-Henning Kamp wrote: > -------- > In message <52374125.OgxafgljNu@ralph.baldwin.cx>, John Baldwin writes: > > >Create the corresponding device_t but device_disable() it when there > >is a disabled property. > > That also removes a couple of boilerplate lines from all FDT device > drivers. That would be useful, but the status bit is so much more than on/off. >A user can then use 'devctl enable ' to enable > >it before (or even after) loading a device driver. > > That would work for me. > > I wonder if it would be too noisy if we allowed ->probe() to run > on disabled devices and reported something like: > > "foobar0: Matched disabled device <...>" > > (without calling ->attach()) > > That way you would know you loaded the right driver, rather > than have to guess. I suspect that would be too noisy. It would be better to just run probe, but then have newbus report it's disabled so we never go onto attach. Though, there's more fundamental issues at play since FDT is tricky and a lot more interrelated than other enumeration platforms. Warner