Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Jan 2024 13:27:50 +0100
From:      Moin Rahman <bofh@freebsd.org>
To:        Jan Beich <jbeich@FreeBSD.org>
Cc:        Gleb Popov <arrowd@FreeBSD.org>, "ports-committers@freebsd.org" <ports-committers@FreeBSD.org>, "dev-commits-ports-all@freebsd.org" <dev-commits-ports-all@FreeBSD.org>, "dev-commits-ports-main@freebsd.org" <dev-commits-ports-main@FreeBSD.org>
Subject:   Re: git: c841c52f8c28 - main - x11/sfwbar: Install mans to share and sort plist.
Message-ID:  <7630EBAB-D395-461A-9EF5-4EEAF6C99750@freebsd.org>
In-Reply-To: <jzoe-n3e8-wny@FreeBSD.org>
References:  <202401121141.40CBf5jY067089@gitrepo.freebsd.org> <jzoe-n3e8-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_A96BBCB0-893C-4045-8550-B7643F24908D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii



> On Jan 12, 2024, at 1:26 PM, Jan Beich <jbeich@FreeBSD.org> wrote:
>=20
> Gleb Popov <arrowd@FreeBSD.org> writes:
>=20
>>   x11/sfwbar: Install mans to share and sort plist.
>=20
> Mixing style and functional changes makes pkg-plist diff hard to read.
> See also =
https://docs.freebsd.org/en/articles/committers-guide/#_other_suggestions
>=20
>> -MESON_ARGS=3D -Dbsdctl=3Denabled -Dnetwork=3Denabled -Dbluez=3Denabled=
 -Didleinhibit=3Denabled -Diwd=3Denabled
>> +MESON_ARGS=3D -Dbsdctl=3Denabled -Dnetwork=3Denabled -Dbluez=3Denabled=
 \
>> + -Didleinhibit=3Denabled -Diwd=3Denabled --mandir=3Dshare/man
>=20
> Why not fix USES=3Dmeson itself?
>=20
> diff --git a/Mk/Uses/meson.mk b/Mk/Uses/meson.mk
> index ae997ae1a337..3a6ae041ff97 100644
> --- a/Mk/Uses/meson.mk
> +++ b/Mk/Uses/meson.mk
> @@ -33,7 +33,7 @@ BUILD_DEPENDS+=3D meson:devel/meson
> USE_LOCALE?=3D en_US.UTF-8
>=20
> CONFIGURE_ARGS+=3D --prefix ${PREFIX} \
> - --mandir man \
> + --mandir share/man \
> --infodir ${INFO_PATH}
>=20
> # Enable all optional features to make builds deterministic. Consumers =
can

Incoming tonight.

Kind regards,
Moin

--Apple-Mail=_A96BBCB0-893C-4045-8550-B7643F24908D
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmWhMEZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE
Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA
vJFcUBAAhPNBlctP9YlUacuzmaJ0kEOZkzE99x8g8yQSEHpUzbU1kPL+1Vjkkrgm
oPxtlVZaBwBCjHjoenwK9UH8Ak5zzhOTCwZi2DEGWyJRO5BCOdBWqZDaUf5Ja3yy
wHTQgBnokGIO/O6dZmG9R6QQgHBoQ3/BSIlSF/Vk3AcR0tzJ4MX2FnQbsxQi9Mqw
x8MRjVLr/CVQ4OBv7jStcTTiFGJ6X1xnGtrrWT1Q0ArVcxgzwjarMpU7SI1xPTqL
mGoV7WjlGVUtwjNVpjehydSlt2DlGgB9W1DAuD82vNv2S7eRwW19rmKHTZ8pb1jX
2HvkQzBqku4B7BKLv0/ZPIJhayyD4TTY57ImuYUUmL8qUFuNEIhTs/Ry/Mk3XlCx
ZbJuwlfWdCawprSn51a/+lWK6YHvfr2mmGWHSocBHb2iPGrEtwVBHPaBYfOLH2Tz
0AFh+rF1DjIe+7OYVRmFIddGB5r0uPHdYOftQX9yFtv1sbu36N1DS6ehoauiXXW5
nxSg63yYsGgQ9hRtAS7xMqsZIU049H8dAIr+nn7tokwNXo4EXZWWcSFVW+WXsvNC
c/k3SARf1cBFckI+u5UUjXOfyF9HwO7XRFgpSdg7UXozX6CvnW974acWjdZwwmW/
JkCEMY7qW9ZvPTPyn9nVTPyhMRDnc7FwYUZcgwJ85UhZ4TAWRFA=
=RSbs
-----END PGP SIGNATURE-----

--Apple-Mail=_A96BBCB0-893C-4045-8550-B7643F24908D--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7630EBAB-D395-461A-9EF5-4EEAF6C99750>