From owner-freebsd-testing@FreeBSD.ORG Wed Apr 2 16:31:46 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 64E58164 for ; Wed, 2 Apr 2014 16:31:46 +0000 (UTC) Received: from mail-we0-x233.google.com (mail-we0-x233.google.com [IPv6:2a00:1450:400c:c03::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F3E9C8E0 for ; Wed, 2 Apr 2014 16:31:45 +0000 (UTC) Received: by mail-we0-f179.google.com with SMTP id x48so495534wes.24 for ; Wed, 02 Apr 2014 09:31:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=pE64YYplw7/D1nGx1Gb/IraxqKtLr5yA3xd2k7FM5aU=; b=Q+pq2BIkSKfRyj+BZobl7LCZUccgbcxn471Rxty8f6w+ESMPYTzmuEEvFT7ENXBJji 1F8ymYniJri5MK7Pc5ecD0pzmM++/w0h3cNYtvr1radVu0pbMqcy9mBdT0cyUp4oDnZv thFBU78LLrrxoJh+vUpwVTkckAbBwZwOCXR7cyXnvjg1AELVZ35WJ2D8hbHu2h+oEpDd GWeDuUA+PCmFvo9kT0C/ulvTyS+pYj9/1i+fJmrrr6gyzSfZ0dBIrPDTQgR2u8RxbdxS uwjxXOeLFpzyMAXdw9Nu2aGCzbmFVMaXJ/vtT5TeDiMzqO5SVgch0d7zBej/ppPmgcm7 nzOw== MIME-Version: 1.0 X-Received: by 10.180.187.16 with SMTP id fo16mr30016165wic.26.1396456304174; Wed, 02 Apr 2014 09:31:44 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.194.168.130 with HTTP; Wed, 2 Apr 2014 09:31:44 -0700 (PDT) In-Reply-To: <20140402085349.GA61802@x2.osted.lan> References: <20140402085349.GA61802@x2.osted.lan> Date: Wed, 2 Apr 2014 10:31:44 -0600 X-Google-Sender-Auth: 3_YJIa1QJuvh0krVHQDPLvfBozw Message-ID: Subject: Re: ATF work From: Alan Somers To: Peter Holm Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2014 16:31:46 -0000 On Wed, Apr 2, 2014 at 2:53 AM, Peter Holm wrote: > I have uploaded a snapshot of the ATF work done for EMC Isilon, > based primarily on Garrett Cooper's work. > > http://people.freebsd.org/~pho/FreeBSD-HEAD-ATF-Isilon-20140401.diff.xz > + > chmod +x /usr/src/lib/libc/tests/net/gen_ether_subr Holy patch queue, Batman! There's fifty thousand lines of code in here! I'm not going to read every line, but here's what I noticed: All of the files from NetBSD should have a $FreeBSD:$ tag alongside the NetBSD tag. lib/libc/tests/net/getaddrinfo/Makefile has some commented out code that should be removed. So does lib/libc/tests/net/getaddrinfo/t_getaddrinfo.sh. Could lib/libc/tests/net/gen_ether_subr be converted to an awk script by replacing the first line with "#!/usr/bin/awk -f" and removing the invocation to awk? Then it would have the correct syntax highlighting in editors. lib/libc/tests/net/Makefile has one tested comment out with the comment "test uses rump". Would it be possible instead to leave the test in the build, but put "require.progs rump_server" in the relevant test cases' heads? It would be more idiomatic for lib/libc/tests/tls_dso/Makefile to define a TESTSDIR variable and use that in the definitions of LIBDIR and SHLIBDIR. lib/libc/tests/gen/Makefile has several tests commented out. Several of the comments are confusingly short (what does "XXX: F_MAXFD DNE" mean)? And the "#ATF_TESTS+= posix_spawn" line should be deleted. lib/libc/tests/gen/posix_spawn/Makefile contains commented out code. lib/libc/tests/arch contains subdirectories that FreeBSD doesn't support and never will, like Vax. They should be deleted. It's unfortunate that all of t_sha2 is disabled. I don't understand the comment, either. Is it disabled just because FreeBSD doesn't have sha384 functions? We have both sha1 and sha256 in libc. lib/libc/tests/termios/Makefile has WARNS=4 commented out. Why is that? Some Makefiles define "MAN= ". It is more idiomatic to define "NOMAN=". Check your whitespace in tests/sys/kern/kern_fork_test.c and tests/sys/kern/user_test.c. I see lines with leading spaces. I tried to test your patch, but I was unable to apply it. It looks like you did "diff -dur src /usr/src" or something like that. The problem is that the two paths need different levels of directories to be stripped. Neither patch nor svn patch can deal with that. The result is that either the newly created files appear in the wrong place, or the tool patches /usr/src/Makefile when it's supposed to patch /usr/src/tests/Makefile and /usr/src/libc/Makefile. Could you please try to regenerate the patch? -Alan > > - Peter > _______________________________________________ > freebsd-testing@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-testing > To unsubscribe, send any mail to "freebsd-testing-unsubscribe@freebsd.org"