From owner-freebsd-current@freebsd.org Tue Jul 7 23:25:06 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DE41F350042 for ; Tue, 7 Jul 2020 23:25:06 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B1dnt3x7Rz4FQm; Tue, 7 Jul 2020 23:25:06 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x82f.google.com with SMTP id j10so33141686qtq.11; Tue, 07 Jul 2020 16:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xA9nvPfBj7xPw0wtsRuqu0Z6WKpcIOjH0dhfgz/E92Q=; b=VuijDB7NPefF71yIoHp14Si6S4ZxUodc2mSvuGIZv0Z099uWPFpg5gFRCvoMLqJdTt lIPNPI9PYtnsrj130FTOvTs2ePH7jlp1CaIAPsK7cjJwyV+JdJtzhQe8d9v/mjEWWabp SMoC2VphwFa2TC1oNxHwHhk9FNMpkEkIpFCecQZOom2fDQKzvkQfXKUlAvJDx6NZ/PHQ JuCdSZnLRpNuMNRjmnah9e4+ZhXrBJJ9374PCIAYjxMW9k4qDnA8G5DQ6g6WaUphbzYS NxV7ZkvkyaunSE1yxjbtv9UhMzM6SqLhfnPNyQ4h2AE0m8Ku8gRs91DMJvtsg1ZDkL9e aMXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=xA9nvPfBj7xPw0wtsRuqu0Z6WKpcIOjH0dhfgz/E92Q=; b=b7V4dCa27iyBQyWpZrL0cvgvEG6Y8nYqMwfXBDuDvZ1kC4IMWCiAABKgq3O2gmzMUZ hC+k1AR8UitEQ7z28aYimXIjzDmA3vaBiMw/gGAMMNURAeJq1k4EjUlXEwMWWS0NzrjB WFFuaxcRdYyOnw2Yy7fOcxsL5GWsfQoJxb1puaj0TyFzeLOf++0vGbvGgK8v/58B7Byv oPD+9Wdju+/CyWif0oksv5yCoTDpud5in9y7R5FKFo+Il/wglFoyO0HtvVYaaGTH115c EiiErNH4d/7Rkv7Lxec6PB7H39xDCfVO0D+UXuOk5s6vclYMzTCrFzfZO2vBsqroqldc z9SQ== X-Gm-Message-State: AOAM530Eki9TkJYfHRSeX3TIM2vSHhTPo8nFHe35VRY9AKQBHJk5JZu7 bl7FgQvNDxf+d6xfuW7RTXywvmuKVRA= X-Google-Smtp-Source: ABdhPJwaZ6pKECLfv0aIoQJuIWLry9cTe74kz9ByPlxxt13JK1LD6BL/gdgO9c5lzW3j6jl8+KtmZQ== X-Received: by 2002:aed:242f:: with SMTP id r44mr29320372qtc.368.1594164304847; Tue, 07 Jul 2020 16:25:04 -0700 (PDT) Received: from raichu (bras-base-toroon0560w-grc-20-184-147-206-12.dsl.bell.ca. [184.147.206.12]) by smtp.gmail.com with ESMTPSA id o10sm27192709qtq.71.2020.07.07.16.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 16:25:03 -0700 (PDT) Sender: Mark Johnston Date: Tue, 7 Jul 2020 19:25:01 -0400 From: Mark Johnston To: Alan Somers Cc: FreeBSD CURRENT Subject: Re: Hardware crypto card wanted Message-ID: <20200707232501.GB51619@raichu> References: <20200707222408.GA51619@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4B1dnt3x7Rz4FQm X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2020 23:25:06 -0000 On Tue, Jul 07, 2020 at 04:36:32PM -0600, Alan Somers wrote: > Yeah, just apply the patch and run the geli tests. The patch add one > additional geli test, too. IIUC, geli doesn't use the thread pool when > it's using hardware crypto, which is why I think it's important that change > be tested both ways. >From my reading of the code that isn't the case, but I might be missing something. r226840 looks like it might be relevant. > The change is here: > https://reviews.freebsd.org/D25587 Works fine using the hardware driver. I had to patch the new test per my comments in the review. > -Alan > > On Tue, Jul 7, 2020 at 4:24 PM Mark Johnston wrote: > > > On Tue, Jul 07, 2020 at 03:18:02PM -0600, alan somers wrote: > > > I'm working on a change to geli, but I need to test it on a system with a > > > hardware crypto card. Not merely one with AES-NI, but one of the old > > > fashioned PCI kind that works with crypto(9). Would anybody who runs > > > CURRENT on such a machine be willing to test my patch for me? > > > > I'm finishing work on a new hardware crypto driver and can test if you > > like. Do you want to run the existing GELI tests with the patch > > applied, or something else? > > > > I don't quite understand why GELI would care about the distinction, > > though. Doesn't GELI use AES-NI via crypto(9) as well? > >