From owner-freebsd-arch@freebsd.org  Thu Feb 11 22:32:41 2016
Return-Path: <owner-freebsd-arch@freebsd.org>
Delivered-To: freebsd-arch@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AED0BAA40C8
 for <freebsd-arch@mailman.ysv.freebsd.org>;
 Thu, 11 Feb 2016 22:32:41 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "mailhost.stack.nl",
 Issuer "CA Cert Signing Authority" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7DB67EC2;
 Thu, 11 Feb 2016 22:32:41 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from toad2.stack.nl (toad2.stack.nl [IPv6:2001:610:1108:5010::161])
 by mx1.stack.nl (Postfix) with ESMTP id 67D083592E1;
 Thu, 11 Feb 2016 23:32:38 +0100 (CET)
Received: by toad2.stack.nl (Postfix, from userid 1677)
 id 30106892B3; Thu, 11 Feb 2016 23:32:38 +0100 (CET)
Date: Thu, 11 Feb 2016 23:32:38 +0100
From: Jilles Tjoelker <jilles@stack.nl>
To: John Baldwin <jhb@freebsd.org>
Cc: freebsd-arch@freebsd.org
Subject: Re: Refactoring asynchronous I/O
Message-ID: <20160211223238.GA73182@stack.nl>
References: <2793494.0Z1kBV82mT@ralph.baldwin.cx>
 <20160210225844.GA89743@stack.nl>
 <1897781.JF7dmmKAT1@ralph.baldwin.cx>
 <2604669.yblYTI1T32@ralph.baldwin.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2604669.yblYTI1T32@ralph.baldwin.cx>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Feb 2016 22:32:41 -0000

On Wed, Feb 10, 2016 at 04:21:30PM -0800, John Baldwin wrote:
> I've pushed a new version with a vfs.aio.enable_unsafe sysctl
> (defaults to off).  If you think this is ok then I'll work on cleaning
> up some of the module bits (removing the unload support mostly).  I
> figure marking the syscalls as STD and removing all the helper stuff
> can be done as a followup commit to reduce extra noise in this diff
> (which is large enough on its own).

> https://github.com/freebsd/freebsd/compare/master...bsdjhb:aio_rework

> (Also, for the inital commit I will leave out the socket protocol
> hook.  That can be added later.)

Looks good to me, except that the error should be [ENOTSUP] instead of
the overloaded [EINVAL].

-- 
Jilles Tjoelker