From owner-cvs-all@FreeBSD.ORG Sun Aug 21 11:44:54 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id CFFC61065672; Sun, 21 Aug 2011 11:44:54 +0000 (UTC) Date: Sun, 21 Aug 2011 11:44:54 +0000 From: Alexey Dokuchaev To: Chris Rees Message-ID: <20110821114454.GA77777@FreeBSD.org> References: <201108211100.p7LB0cB7060742@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.4.2.1i Cc: Rene Ladan , cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/www/chromium Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Aug 2011 11:44:54 -0000 On Sun, Aug 21, 2011 at 12:04:37PM +0100, Chris Rees wrote: > On 21 August 2011 12:00, Rene Ladan wrote: > > rene š š š š2011-08-21 11:00:38 UTC > > > > šModified files: > > š šwww/chromium š š š š Makefile > > šLog: > > šDo not hardcode the patch directory as "files", use ${FILESDIR} instead. > > Shouldn't it be PATCHDIR? Ideally, only one should stay, I don't really care which one (although FILESDIR is maybe a bit better as it's more generic -- there might be not only patches, but drop-in files, etc). I wanted to look at merging FILESDIR/PATCHDIR logic in bpm several years ago, but didn't go much further. ./danfe