From owner-svn-src-all@FreeBSD.ORG Mon Apr 6 16:48:55 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EBEF61065766; Mon, 6 Apr 2009 16:48:55 +0000 (UTC) (envelope-from scode@hyperion.scode.org) Received: from hyperion.scode.org (cl-1361.ams-04.nl.sixxs.net [IPv6:2001:960:2:550::2]) by mx1.freebsd.org (Postfix) with ESMTP id A382E8FC14; Mon, 6 Apr 2009 16:48:55 +0000 (UTC) (envelope-from scode@hyperion.scode.org) Received: by hyperion.scode.org (Postfix, from userid 1001) id E0C2C23C471; Mon, 6 Apr 2009 18:48:53 +0200 (CEST) Date: Mon, 6 Apr 2009 18:48:53 +0200 From: Peter Schuller To: Vasil Dimov Message-ID: <20090406164853.GA75904@hyperion.scode.org> References: <200903142010.n2EKAESF006945@svn.freebsd.org> <20090320140015.GA17645@hub.freebsd.org> <20090320153405.GA62675@zim.MIT.EDU> <49C3BCD4.4030605@freebsd.org> <1237567495.1993.2.camel@localhost> <20090327063251.GA95057@polejan.hw.v5d.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OwLcNYc0lM97+oe1" Content-Disposition: inline In-Reply-To: <20090327063251.GA95057@polejan.hw.v5d.org> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Sam Leffler , Coleman Kane , src-committers@FreeBSD.org Subject: Re: svn commit: r189828 - in head: include sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2009 16:48:56 -0000 --OwLcNYc0lM97+oe1 Content-Type: multipart/mixed; boundary="5vNYLRcllDrimb99" Content-Disposition: inline --5vNYLRcllDrimb99 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable [ pthread_kill() in signal.h conflicting with devel/pth's attempts to hide = native pthread] > 3. /usr/include/signal.h defines pthread_kill() only if __POSIX_VISIBLE > or __XSI_VISIBLE is defined. Can someone try to inject > #undef __POSIX_VISIBLE or #undef __XSI_VISIBLE into pth's pthread.h.in > to see if this fixes the problem and does not cause other problems? The attached patch dropped into the port makes devel/pth and security/gnupg build for me. I'll re-build my full set of ports with the patch and see, but I'm not really set up to do a global build of all ports. More importantly I guess is that it doesn't break things on older releases. I'll re-build my ports on a 7.x system too. I'm not the most knowledgable about the various POSIX/XSI compatibility defines and their expected results, but it seems pretty dangerous to me to flat-out #undef it. Who knows what else depends on those being set properly in any given application. How about only doing it for a new enough OS release to at least avoid breaking older releases, and then communicate the problem upstream and hope for a better fix? --=20 / Peter Schuller PGP userID: 0xE9758B7D or 'Peter Schuller ' Key retrieval: Send an E-Mail to getpgpkey@scode.org E-Mail: peter.schuller@infidyne.com Web: http://www.scode.org --5vNYLRcllDrimb99 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch-pth_p.h.in" Content-Transfer-Encoding: quoted-printable --- pth_p.h.in.orig 2009-04-06 18:33:15.490908975 +0200 +++ pth_p.h.in 2009-04-06 18:33:32.490533854 +0200 @@ -26,6 +26,9 @@ #ifndef _PTH_P_H_ #define _PTH_P_H_ =20 +#undef __POSIX_VISIBLE +#undef __XSI_VISIBLE + /* mandatory system headers */ #include #include --5vNYLRcllDrimb99-- --OwLcNYc0lM97+oe1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAknaMnUACgkQDNor2+l1i31izACgoCSUiwmvnRToGrweeRc5DZHk vykAnjTccJ36d2iDo45jiIyMs9MU7A+O =Fush -----END PGP SIGNATURE----- --OwLcNYc0lM97+oe1--