From owner-freebsd-isdn Tue Sep 10 9:42: 0 2002 Delivered-To: freebsd-isdn@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B689737B400 for ; Tue, 10 Sep 2002 09:41:58 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id E994743E6A for ; Tue, 10 Sep 2002 09:41:57 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g8AGfbUk011465; Tue, 10 Sep 2002 18:41:42 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Gary Jennejohn Cc: isdn@freebsd.org Subject: Re: Found a cheap ISDN card today -- and a bug in -CURRENT In-Reply-To: Your message of "Tue, 10 Sep 2002 16:34:37 +0200." <200209101434.g8AEYb1Z001069@peedub.jennejohn.org> Date: Tue, 10 Sep 2002 18:41:37 +0200 Message-ID: <11464.1031676097@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org In message <200209101434.g8AEYb1Z001069@peedub.jennejohn.org>, Gary Jennejohn w rites: >Poul-Henning Kamp writes: >> >> I found a pre-owned PCI ISDN card for 3euro today, and promptly >> went back home to plug it into my -current machine: >> >> Anyone interested ? >> > >I think the driver is missing an mtx_initialize() of the mutex >in struct ifq. I added it to a bunch of drivers, but not to >layer1/itjc/i4b_itjc_pci.c. Try adding it and see what happens. Bingo, thanks. I'm surprised to see so much repeated code in all the layer1 drivers, couldn't some of this be factored out to central code ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message