From owner-freebsd-current@FreeBSD.ORG Thu Apr 5 14:38:11 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D1E86106564A; Thu, 5 Apr 2012 14:38:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id A87158FC18; Thu, 5 Apr 2012 14:38:11 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 17A8CB95A; Thu, 5 Apr 2012 10:38:11 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org, jasone@freebsd.org Date: Thu, 5 Apr 2012 09:33:07 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; ) References: <431CB493-836B-4DF4-AC42-A7C6ABF7DE3E@canonware.com> In-Reply-To: <431CB493-836B-4DF4-AC42-A7C6ABF7DE3E@canonware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201204050933.07368.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 05 Apr 2012 10:38:11 -0400 (EDT) Cc: Subject: Re: contrib/jemalloc X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2012 14:38:11 -0000 On Thursday, April 05, 2012 12:56:45 am Jason Evans wrote: > I have the current version of jemalloc integrated into libc as contrib/jemalloc: > > http://people.freebsd.org/~jasone/patches/jemalloc_20120404b.patch > > This is the first update to FreeBSD's jemalloc in over two years, and the differences are huge (faster, better introspection, hopefully fewer bugs). This has been stable for me across numerous buildworld/installworld iterations, as well as when running several benchmarks. There's a bugfix to openpam in the patch that des says will be obsoleted by the next vendor import, so I'm planning to let that settle before committing. In the meanwhile, I'm hoping for some review sanity checks on the following aspects of the patch: > > * Are the symbol versioning specifications right, and are the compatibility symbols for _malloc_options and _malloc_message workable? > > * Is it acceptable to check this in directly to trunk without using a vendor branch? For the import workflow I have planned, a vendor branch would just be extra work with no benefit that I can see. > > * Is the light editing of the jemalloc manual page sufficient? Keeping the changes minimal will make regular imports less work, but the result is less tailored to FreeBSD. > > * Will the utrace feature be missed? I removed it some time ago, mainly because traces are impossibly large for most real-world use cases. I will only speak to this one. I do still find this useful (I used it most recently a week or so ago). It would be nice to keep if it is not a major pain to maintain. -- John Baldwin