From owner-freebsd-current Tue Oct 29 23:23:22 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4376937B401 for ; Tue, 29 Oct 2002 23:23:21 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id CFA2843E91 for ; Tue, 29 Oct 2002 23:23:20 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 89304 invoked by uid 1000); 30 Oct 2002 07:23:23 -0000 Date: Tue, 29 Oct 2002 23:23:23 -0800 (PST) From: Nate Lawson To: Dag-Erling Smorgrav Cc: Bill Fenner , freebsd-current@freebsd.org Subject: Re: libfetch(3) patch for SSL In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 30 Oct 2002, Dag-Erling Smorgrav wrote: > Dag-Erling Smorgrav writes: > > I'd rather fix it like this: > > Oomph, of course this doesn't work in the !ssl case. I would really > prefer a solution that allowed wlen == 0 if we actually *intended* not > to write anything, but I can't figure out a clean, quick way to do it > right now. I guess your patch will have to do for now. May I humbly propose that the API is broken and should be reworked? My frustration with cached_connection common/ftp sharing and this thrashing trying to overload the return value are signs that the API needs rethinking. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message