From owner-freebsd-current@freebsd.org  Sun Jul 15 18:03:54 2018
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2FBA01049118
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Sun, 15 Jul 2018 18:03:54 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D2CC491177;
 Sun, 15 Jul 2018 18:03:53 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: from mail-it0-f53.google.com (mail-it0-f53.google.com
 [209.85.214.53])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 (Authenticated sender: mmacy)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 9469C237F4;
 Sun, 15 Jul 2018 18:03:53 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: by mail-it0-f53.google.com with SMTP id 198-v6so9777026ite.4;
 Sun, 15 Jul 2018 11:03:53 -0700 (PDT)
X-Gm-Message-State: AOUpUlFMHjJI82DhAGN5SrLd28uXFPnn5KG4LBhCwpuS2yLyuyjgl3/S
 wtEW5NJyp4ZfmRykqCyFC7lVy3wGK2VDG593/0g=
X-Google-Smtp-Source: AAOMgpedsNO06O70us9+SwcETX9AXje4XmHmAB0QvuXbvlSl4xxV5Q+dGE8cobypvOMEhTj4+ynK4tt3+YAVOyY1w5w=
X-Received: by 2002:a24:6c04:: with SMTP id w4-v6mr10403787itb.4.1531677832708; 
 Sun, 15 Jul 2018 11:03:52 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a02:8d2:0:0:0:0:0 with HTTP;
 Sun, 15 Jul 2018 11:03:52 -0700 (PDT)
In-Reply-To: <CANCZdfrYrz0971Grk5E-hrQd+APZVfNewvDPj19D-T_JZ_1kJw@mail.gmail.com>
References: <20180715150638.GA30154@troutmask.apl.washington.edu>
 <1531674041.26036.1.camel@freebsd.org>
 <20180715171737.GA31164@troutmask.apl.washington.edu>
 <CAHM0Q_OMYUe4CDemC8Gx9AGzA+wK0cctwUhHieeQi2xdDs0urA@mail.gmail.com>
 <CANCZdfrYrz0971Grk5E-hrQd+APZVfNewvDPj19D-T_JZ_1kJw@mail.gmail.com>
From: Matthew Macy <mmacy@freebsd.org>
Date: Sun, 15 Jul 2018 11:03:52 -0700
X-Gmail-Original-Message-ID: <CAPrugNqXd9ar1Qv3L_ae++nmvxOeX1v+RqpTf3FVu=0BXm7dvA@mail.gmail.com>
Message-ID: <CAPrugNqXd9ar1Qv3L_ae++nmvxOeX1v+RqpTf3FVu=0BXm7dvA@mail.gmail.com>
Subject: Re: [PATCH] Recent libm additions
To: Warner Losh <imp@bsdimp.com>
Cc: Steve Kargl <sgk@troutmask.apl.washington.edu>,
 Ian Lepore <ian@freebsd.org>, 
 FreeBSD Current <freebsd-current@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Jul 2018 18:03:54 -0000

On Sun, Jul 15, 2018 at 10:55 AM, Warner Losh <imp@bsdimp.com> wrote:
> On Sun, Jul 15, 2018, 11:23 AM K. Macy <kmacy@freebsd.org> wrote:
>
>> >
>> > Well, actually, the functions in polevll.c should have been copied
>> > into ld80/e_powl.c, and polevall.c should never have been committed.
>> > Unfortunately, the code was not reviewed for correctness.
>>
>> That is not correct. Please stop repeating it. Bruce Evans and John
>> Baldwin were both looped in. Neither made this observation.
>>
>
> Steve is the fp guy these days. And it wasn't reviewed by him. He's mad you
> cut him out of the loop. Arguing about pedantic points of process does no
> one any good.

Thanks for the tip. I'm sorry. I was under the impression that he gave
up his bit: https://reviews.freebsd.org/rD46886

So we have a maintainer who has opted to not have a bit. So be it.

Nonetheless, reviews.freebsd.org is the established channel by which
the project does code reviews. I stand by my recommendation and will
add him to reviews in the future.