From owner-cvs-src@FreeBSD.ORG  Wed Apr 13 19:53:12 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6ADF316A4CE; Wed, 13 Apr 2005 19:53:12 +0000 (GMT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3D71943D39; Wed, 13 Apr 2005 19:53:12 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 378615CA2C; Wed, 13 Apr 2005 12:53:12 -0700 (PDT)
Date: Wed, 13 Apr 2005 12:53:12 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: "Matthew N. Dodd" <mdodd@FreeBSD.ORG>
Message-ID: <20050413195312.GD60345@elvis.mu.org>
References: <200504130001.j3D01kuD081602@repoman.freebsd.org>
	<20050413184246.19212b84.antoine.brodin@laposte.net>
	<20050413124956.M3762@sasami.jurai.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050413124956.M3762@sasami.jurai.net>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
cc: Antoine Brodin <antoine.brodin@laposte.net>
Subject: Re: cvs commit: src/share/man/man4 unix.4 src/sys/sys socket.h un.h
	unpcb.h src/sys/kern uipc_usrreq.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Apr 2005 19:53:12 -0000

* Matthew N. Dodd <mdodd@FreeBSD.ORG> [050413 10:04] wrote:
> On Wed, 13 Apr 2005, Antoine Brodin wrote:
> >I'm not sure it's safe to sooptcopyout/sooptcopyin while holding the
> >unp mutex in uipc_ctloutput.  It can fault.
> 
> I was concerned about this but saw that other code holds locks across 
> sooptcopy*() calls.
> 
> If there is a deadlock problem it may be time to add a per unpcb lock.

This should be tripping an assertion, copyout/copyin is not ok while
holding a mutex.  Does anyone want to add the logic to sooptcopy*?

-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684