From owner-p4-projects@FreeBSD.ORG  Thu Apr 22 22:33:44 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E2A5E16A4D1; Thu, 22 Apr 2004 22:33:43 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B9AC316A4CE; Thu, 22 Apr 2004 22:33:43 -0700 (PDT)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4678243D1D; Thu, 22 Apr 2004 22:33:43 -0700 (PDT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.10/8.12.9) with ESMTP id i3N5Xggr075597;
	Thu, 22 Apr 2004 23:33:42 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Thu, 22 Apr 2004 23:33:50 -0600 (MDT)
Message-Id: <20040422.233350.119859738.imp@bsdimp.com>
To: marcel@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200404230321.i3N3LxhW010292@repoman.freebsd.org>
References: <200404230321.i3N3LxhW010292@repoman.freebsd.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: perforce@freebsd.org
Subject: Re: PERFORCE change 51597 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 05:33:44 -0000

In message: <200404230321.i3N3LxhW010292@repoman.freebsd.org>
            Marcel Moolenaar <marcel@freebsd.org> writes:
: http://perforce.freebsd.org/chv.cgi?CH=51597
: 
: Change 51597 by marcel@marcel_nfs on 2004/04/22 20:21:30
: 
: 	Provide a stopgap fix for the sparc64 ebus breakage
: 	due to the PCI mega-commit. Soon to appear in a CVS
: 	repository near you.
:
: Affected files ...
: 
: .. //depot/projects/gdb/sys/dev/pci/pci.c#7 edit
: 
: Differences ...
: 
: ==== //depot/projects/gdb/sys/dev/pci/pci.c#7 (text+ko) ====
: 
: @@ -825,6 +825,12 @@
:  	if (base == 0)
:  		return 1;
:  
: +	/* Sun EBus bridges contain the ranges for the devices beyond them */
: +	if ((pci_get_class(dev) == PCIC_BRIDGE) &&
: +	    (pci_get_vendor(dev) == 0x108e) &&
: +	    (pci_get_device(dev) == 0x1000 || pci_get_device(dev) == 0x1100))
: +		return 1;
: +
:  	start = base;
:  	end = base + (1 << ln2size) - 1;
:  	count = 1 << ln2size;

Shouldn't the ebus bridge device be allocating the resources and
giving them to their children?  This isn't the right fix and I'd like
to work with you to the fix at the right level...

Warner