From owner-cvs-all Tue Dec 11 8:59:47 2001 Delivered-To: cvs-all@freebsd.org Received: from columbus.cris.net (columbus.cris.net [212.110.128.65]) by hub.freebsd.org (Postfix) with ESMTP id 59FBD37B405; Tue, 11 Dec 2001 08:59:29 -0800 (PST) Received: from ark.cris.net (ns2.cris.net [212.110.128.68]) by columbus.cris.net (8.9.3/8.9.3) with ESMTP id SAA04901; Tue, 11 Dec 2001 18:59:20 +0200 (EET) Received: (from phantom@localhost) by ark.cris.net (8.11.1/8.11.1) id fBBGwl702193; Tue, 11 Dec 2001 18:58:47 +0200 (EET) Date: Tue, 11 Dec 2001 18:58:47 +0200 From: Alexey Zelkin To: Josef Karthauser Cc: Peter Wemm , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/gnu/usr.bin/binutils/gdb/i386 kvm-fbsd.c Message-ID: <20011211185847.A99187@ark.cris.net> References: <200112110704.fBB74mk31239@freefall.freebsd.org> <20011211164118.B27214@tao.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: <20011211164118.B27214@tao.org.uk>; from joe@tao.org.uk on Tue, Dec 11, 2001 at 04:41:18PM +0000 X-Operating-System: FreeBSD 3.5-STABLE i386 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG hi, On Tue, Dec 11, 2001 at 04:41:18PM +0000, Josef Karthauser wrote: > > peter 2001/12/10 23:04:48 PST > > > > Modified files: > > gnu/usr.bin/binutils/gdb/i386 kvm-fbsd.c > > Log: > > (null) > > Is it worth having the commit fail if there's a null log message? It could be useful as for me. But make sure that it should work correctly in both pserver and local modes. In pserver mode it's not a problem to check for null commit log and fail since all files are comiting at once, but in local mode following scenario may exists: . hack files in few directories . do cvs commit . write correct log for first directory files . emptify log for second directory in this case scripts will fail to continue and don't send email with "(null)" content, but patches for first directory are already applied. As result we have complete commit (at least part) and no notification sent. PS: What about fix with current "$FreeBSD$ line mungled" CVSROOT problem ? Bunch of patches from my tree awaiting to be commited! :) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message