From owner-freebsd-net@FreeBSD.ORG Sun Sep 13 01:30:06 2009 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E7A72106566C for ; Sun, 13 Sep 2009 01:30:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D64138FC0A for ; Sun, 13 Sep 2009 01:30:06 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n8D1U6Tl021192 for ; Sun, 13 Sep 2009 01:30:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n8D1U6pc021189; Sun, 13 Sep 2009 01:30:06 GMT (envelope-from gnats) Date: Sun, 13 Sep 2009 01:30:06 GMT Message-Id: <200909130130.n8D1U6pc021189@freefall.freebsd.org> To: freebsd-net@FreeBSD.org From: Bruce Simpson Cc: Subject: Re: kern/138666: [multicast] [panic] not working multicast through igmpproxy X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bruce Simpson List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Sep 2009 01:30:07 -0000 The following reply was made to PR kern/138666; it has been noted by GNATS. From: Bruce Simpson To: freebsd-gnats-submit@FreeBSD.org Cc: freebsd-net@FreeBSD.org Subject: Re: kern/138666: [multicast] [panic] not working multicast through igmpproxy Date: Sun, 13 Sep 2009 02:04:52 +0100 I did a quick pass over ip_mroute.c to see if I could have introduced any obvious errors during refactoring; didn't see anything obvious. The backtrace which was posted points towards a trashed rte->m pointer, assuming it's accurate and the arguments didn't get trashed on-stack. The MFC lock should be held in expire_mfc(). I'll add a lock assertion there for now. The VIF lock shouldn't be needed in this path.