From owner-freebsd-current  Sun Aug 11 13:39:29 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9C3EC37B400; Sun, 11 Aug 2002 13:39:27 -0700 (PDT)
Received: from viola.sinor.ru (viola.sinor.ru [217.70.106.9])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9CC5143E5E; Sun, 11 Aug 2002 13:39:26 -0700 (PDT)
	(envelope-from semenu@FreeBSD.org)
Received: from tlg5-ppp71.sibnet.ru (tlg5-ppp71.sibnet.ru [217.70.116.71])
	by viola.sinor.ru (8.12.3/8.12.3) with ESMTP id g7BKcahb024694;
	Mon, 12 Aug 2002 03:38:58 +0700
Date: Mon, 12 Aug 2002 03:37:40 +0700 (NOVST)
From: "Semen A. Ustimenko" <semenu@FreeBSD.org>
X-X-Sender: semenu@main.the.net
To: Robert Watson <rwatson@FreeBSD.org>
Cc: Maxim Konovalov <maxim@FreeBSD.org>,
	Gavin Atkinson <gavin@ury.york.ac.uk>, <current@FreeBSD.org>
Subject: Re: sendfile(2) is broken (Was: ftpd problem: Input/output error)
In-Reply-To: <Pine.NEB.3.96L.1020811111707.53301A-100000@fledge.watson.org>
Message-ID: <20020812033540.F1596-100000@main.the.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

Hi!

On Sun, 11 Aug 2002, Robert Watson wrote:

> On Sun, 11 Aug 2002, Maxim Konovalov wrote:
>
> > This is sendfile(2) mis-behaviour arised after rev.1.109
> > sys/kern/uipc_syscalls.c but I think the real problem in vn_rdwr(),
> > sys/kern/vfs_vnops.c. Here is my patch but I really need somebody with
> > vfs clue. I CC'ed Robert Watson as an author of sendfile(2)
> > modification and our vfs expert.
>
> Semen Ustimenko <semenu@FreeBSD.org> ran into a similar problem, but his
> fix was to teach sendfile() to pass in a non-NULL resid and handle the
> failure mode better.  I suspect this fix is more correct since it will
> both handle the failure mode and the data delivered, and probably is
> required for other consumers of vn_rdwr().  He was going to run the patch
> past dg, and then commit it assuming dg approved it, so hopefully it will
> go into the tree in the next day or so.
>

David reviewed the patch and I have committed it few minutes ago.

Thanks!


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message