From nobody Thu Oct 19 03:07:29 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S9t1Y68qhz4xsCY for ; Thu, 19 Oct 2023 03:07:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S9t1Y57wWz4G7F for ; Thu, 19 Oct 2023 03:07:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697684849; a=rsa-sha256; cv=none; b=shdf86lhkmfWMbzrpH2xLNHhaA3jh3Ef78VfHZzLlgCBCXVkAqOFdQ4sF4LiPyAzv/ZvCp wAYFn4kwSIiF9IuTzfSYu0UdI0qxRBamcyTyUTvgF0Z262B/XDtEv4IR5mxRulrgWKSxYF V0HqgsnB1cDDDCPRbCyp4QeezUT/7Gn+D6Y6yHcXk0uVAfiTRFpy+if9uDn34o7UZYi8QD 7s6J6+nhO90Tu1wK2oLRM5A38MdjRWVy6hVKf9zXKpXZEIHnkLk3BBGkSEH61ED2pHn283 eA5GnfgCqrgwyt9WkBj939cq+thtIm4APY2vEVUChbSZ/dqJUEge6/rDfdI+eQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697684849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xTw1mDMB9N4ChWWudEEAmrwU4dkQQnUHbtnk5eUngfk=; b=d4Cp6lRH/d0SiFoJBSfcFuyip4GeVY25iogQgpl3rXVhYG2oyVbSrdap1+GWEbCTohbKSh iVpDrttd/rqog8Xl3ijcGCXKCmYQcZUIo3UpeySyOJtHc6AfTmz+Rytt91C5pMxjR2sYry IoL2hu7eVtn19IpujsF5R3h1lQc5C027DnjgjwInvyBPs4VZOPjO4a8wYJ1+3MijvexplY kIyBiaKlwOHEkVa36HTNUz7JePEwuiQRTbBJXWXyopZ2RTbZokcfHcYA4u7wVyZUsQviC5 dT9CduL8OJ+F5Xu+QGSjdwJgDQhl2WHzIIC3Z3B25t2cuDxpARv5TBZgzuekGA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S9t1Y46BTzYC6 for ; Thu, 19 Oct 2023 03:07:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 39J37TjO082004 for ; Thu, 19 Oct 2023 03:07:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 39J37Tc3082003 for bugs@FreeBSD.org; Thu, 19 Oct 2023 03:07:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273289] smartpqi: fix panic on removal of SAS drive Date: Thu, 19 Oct 2023 03:07:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-STABLE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273289 --- Comment #14 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Db064a4c9eed5b1dd2a40fc4fd2cb7e738= b681547 commit b064a4c9eed5b1dd2a40fc4fd2cb7e738b681547 Author: John F. Carr AuthorDate: 2023-10-19 03:02:42 +0000 Commit: Warner Losh CommitDate: 2023-10-19 03:06:40 +0000 smartpqi: Drop spinlock before freeing memory pqisrc_free_device frees the device softc with the os spinlock held. This causes crashes when devices are removed because the memory free might sleep (which is prohibited with spin locks held). Drop the spinlock before releasing the memory. MFC After: 2 days PR: 273289 Reviewed by: imp sys/dev/smartpqi/smartpqi_discovery.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=