From owner-freebsd-ports@FreeBSD.ORG Sat Nov 25 09:24:03 2006 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from localhost.my.domain (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 8CDBB16A58E; Sat, 25 Nov 2006 09:24:02 +0000 (UTC) (envelope-from davidxu@freebsd.org) From: David Xu To: freebsd-ports@freebsd.org Date: Sat, 25 Nov 2006 17:23:58 +0800 User-Agent: KMail/1.8.2 References: <200611111627.kABGRqbT087375@repoman.freebsd.org> <20061125090433.GB91673@over-yonder.net> In-Reply-To: <20061125090433.GB91673@over-yonder.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611251723.59209.davidxu@freebsd.org> Cc: ports@freebsd.org, barner@freebsd.org, "Matthew D. Fuller" Subject: Re: Valgrind failures (was Re: cvs commit: src/sys/sys sched.h) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2006 09:24:04 -0000 On Saturday 25 November 2006 17:04, Matthew D. Fuller wrote: > > trhodes 2006-11-11 16:27:52 UTC > > > > Modified files: > > sys/sys sched.h > > Log: > > Merge sys/posix4/sched.h into sys/sched.h. > > > > Revision Changes Path > > 1.29 +77 -3 src/sys/sys/sched.h > > This change seems to have broken the build of the valgrind* ports. > The following patch seems to make it build nicely (applies to > valgrind-snapshot with a few lines offset). Neither appear to > actually work on my Thursday -CURRENT, but I don't guess that's really > related to this change. Both versions dump core just trying to run on > 'ls'. > > > (The chosen OSVERSION is from an unrelated change ~30 minutes after > the above) > > > Index: Makefile > =================================================================== > RCS file: /usr/cvs/ports/devel/valgrind/Makefile,v > retrieving revision 1.21 > diff -u -r1.21 Makefile > --- Makefile 4 May 2006 21:41:10 -0000 1.21 > +++ Makefile 25 Nov 2006 08:42:52 -0000 > @@ -87,6 +87,10 @@ > ${FIND} ${WRKSRC} -name "Makefile.in" -exec \ > ${REINPLACE_CMD} -e "s/docs//g" {} \; > .endif > +.if ${OSVERSION} >= 700025 > + ${REINPLACE_CMD} -e "s,posix4/sched\.h,sys/sched\.h," \ > + ${WRKSRC}/coregrind/vg_unsafe.h > +.endif > > post-install: > @${INSTALL_DATA} ${WRKSRC}/coregrind/vg_unistd.h \ I think the ports should use /usr/include/sched.h which has being existed for a long time. Regards, David Xu