Date: Tue, 21 Apr 2015 18:30:43 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 199582] ports-mgmt/portmaster ADOPT (take MAINTAINER) Message-ID: <bug-199582-13-3NTxS8CzoK@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-199582-13@https.bugs.freebsd.org/bugzilla/> References: <bug-199582-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199582 --- Comment #12 from Chris Hutchinson <portmaster@bsdforge.com> --- (In reply to John Marino from comment #11) > (In reply to Chris Hutchinson from comment #10) > > I can *indeed* start providing patches, and will do so. In fact, I can > > post them right here. :) > > I think it would be more appropriate to post patches on the original PRs. > It keeps the topics compartmentalized and it keeps the original reporter in > the loop. > > > Speaking of being at "committer level", may I humbly request your personally > > reviewing those patches? May I also request your being my "mentor"? I can > > think of no one I feel more qualified to do so. I mean that sincerely. This > > is *NOT* "lip service"! > > So we are talking about patches to the 4000-line script, not patches to the > port that installs it, right? (which I assume is dead simple). > > I can look at patches, but they will likely be out of context and I'd have > to review the entire script to put it into context, which implies I'd have > to get intimately familiar with the internals in order to give real > feedback. In reality, if there's a reproducible problem and your patch > clearly fixes it without other regressions, chances are the patch is > correct. I'd really just see you as the primary developer at that point. > > I think it would be more realistic that you would contact someone, including > me, if you are "stuck" on how to solve a stated problem. Then you'd get > pointed in the right direction, solve it, and whatever patch you come up > with would be assumed to be correct (since it comes from the developer) Sure. It all makes perfect sense. Sorry. Thanks! --Chris -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-199582-13-3NTxS8CzoK>