From owner-freebsd-fs@FreeBSD.ORG  Wed Sep 28 13:09:58 2005
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
X-Original-To: fs@freebsd.org
Delivered-To: freebsd-fs@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1BB1516A41F
	for <fs@freebsd.org>; Wed, 28 Sep 2005 13:09:58 +0000 (GMT)
	(envelope-from peadar.edwards@gmail.com)
Received: from zproxy.gmail.com (zproxy.gmail.com [64.233.162.197])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AE10443D55
	for <fs@freebsd.org>; Wed, 28 Sep 2005 13:09:57 +0000 (GMT)
	(envelope-from peadar.edwards@gmail.com)
Received: by zproxy.gmail.com with SMTP id z31so39987nzd
	for <fs@freebsd.org>; Wed, 28 Sep 2005 06:09:57 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=eUEnLNFN3l3Zu0uxmvS4hW8wZj6770YtkOAfHe9jmz0V578jzLEjUv8SJirbDlt4LpD7ln+C+kMkwM4XmyFJ8th1g0SkJW5v1rpb37s3F2kKuVddsbeE813bX4w37Gh0GyI0B2J3cP1ft+L+gL7QKkiFIHZuxkajuYlfC1YITes=
Received: by 10.36.222.3 with SMTP id u3mr1532390nzg;
	Wed, 28 Sep 2005 06:09:57 -0700 (PDT)
Received: by 10.36.68.16 with HTTP; Wed, 28 Sep 2005 06:09:57 -0700 (PDT)
Message-ID: <34cb7c84050928060976c15ecf@mail.gmail.com>
Date: Wed, 28 Sep 2005 14:09:57 +0100
From: Peter Edwards <peadar.edwards@gmail.com>
To: Jim Rees <rees@umich.edu>
In-Reply-To: <20050928125435.620941BBD4@citi.umich.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <20050928125435.620941BBD4@citi.umich.edu>
Cc: fs@freebsd.org
Subject: Re: can not mount a large FAT32 filesystem
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Peter Edwards <peadar.edwards@gmail.com>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Sep 2005 13:09:58 -0000

On 9/28/05, Jim Rees <rees@umich.edu> wrote:
> Note that the check also must be removed near the top of mountmsdosfs(), =
at
> least in the cvs head version.
>
The only reference to BOOTSIG[23] in msdosfs_vnops.c were the ones I
removed: Do you mean here (line 445 of msdos_vfsops.c v 1.144)

> #ifndef MSDOSFS_NOCHECKSIG
>         if (bsp->bs50.bsBootSectSig0 !=3D BOOTSIG0
>             || bsp->bs50.bsBootSectSig1 !=3D BOOTSIG1) {
>                 error =3D EINVAL;
>                 goto error_exit;
>         }
> #endif

This is a different check: It's testing a different signature: the
"0xAA55" marker at the end of the bootblock, which _is_ actually
documented. (And MSDOSFS_NOCHECKSIG is unconditionally defined anyway)