From owner-freebsd-current@FreeBSD.ORG  Thu Nov 15 21:44:46 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 60DE1429;
 Thu, 15 Nov 2012 21:44:46 +0000 (UTC)
 (envelope-from asmrookie@gmail.com)
Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com
 [209.85.217.182])
 by mx1.freebsd.org (Postfix) with ESMTP id 76E288FC0C;
 Thu, 15 Nov 2012 21:44:45 +0000 (UTC)
Received: by mail-lb0-f182.google.com with SMTP id gg13so2108131lbb.13
 for <multiple recipients>; Thu, 15 Nov 2012 13:44:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:reply-to:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=FntpHllDouwqnrIGT0VbU6fCPv4Hg85yZMJs+WRa6DY=;
 b=dTnxR/gqiWEeKDXacNdtjBTR0RYzqscOcT9fu99pIa6QAXOtWmxV0MIhJP/fdoefzi
 QBXgp3wvywOYXYZDWQS9aRCvwVXGjH+aKazJYQhbL7jIzGXVovPwqeVnncr8dlOhwA9g
 L9jOP1FQJYv8xTskXOQxttsDPvJVSEkh4J0RKyxLJzyqv120Dyeu7iiKRa6BNPEOoIZY
 neOxOVKL57pbrwVXPSkWKbqZqjOjn1+6ld8I0qaItEiBrVingLFWjaWBKH9yPnjL80Ap
 1BrbogWVRK7VLuPxuZ1fGO8pFtrrxn+uSSMytRaACtNtZH/PoRIXfy0s6nMpTqwP6hhK
 Nofw==
MIME-Version: 1.0
Received: by 10.152.123.103 with SMTP id lz7mr2378431lab.21.1353015884248;
 Thu, 15 Nov 2012 13:44:44 -0800 (PST)
Sender: asmrookie@gmail.com
Received: by 10.112.134.5 with HTTP; Thu, 15 Nov 2012 13:44:44 -0800 (PST)
In-Reply-To: <50A552C5.5060703@FreeBSD.org>
References: <50A4E8C0.5030608@FreeBSD.org>
 <CAJ-FndAfUPOWzvpXtn7tHfzV00a+1PkfcXmEYo1eNg3RZG4Bew@mail.gmail.com>
 <50A552C5.5060703@FreeBSD.org>
Date: Thu, 15 Nov 2012 21:44:44 +0000
X-Google-Sender-Auth: dTPUs2IPiyxLhF5FOAaNrillnpQ
Message-ID: <CAJ-FndA+NSYDpOuhuFKTf6puPJz9aBSrNH-a-TfRKuqY-ZgAjw@mail.gmail.com>
Subject: Re: LK_SHARED/LK_DOWNGRADE adjustments to lock.9 manual page
From: Attilio Rao <attilio@freebsd.org>
To: Andriy Gapon <avg@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: freebsd-hackers@freebsd.org, freebsd-current@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: attilio@FreeBSD.org
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Nov 2012 21:44:46 -0000

On Thu, Nov 15, 2012 at 8:38 PM, Andriy Gapon <avg@freebsd.org> wrote:
> on 15/11/2012 20:46 Attilio Rao said the following:
>> On 11/15/12, Andriy Gapon <avg@freebsd.org> wrote:
>>>
>>> To people knowing the code,
>>>
>>> do the following documentation changes look correct?
>>
>> The latter chunk is not correct.
>> It will panic only if assertions are on.
>
> But the current content is not correct too?

Indeed, current content is crappy.

>> I was thinking that however
>> it would be good idea to patch lockmgr to panic also in non-debugging
>> kernel situation.
>
> It would make sense indeed, IMO.

Do you think you can test this patch?:
http://www.freebsd.org/~attilio/lockmgr_forcerec.patch

I think the LK_NOSHARE case is still fine with just asserts.

Once this patch goes in, you are free to commit your documentation one.
Thanks for fixing doc.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein