From owner-svn-ports-head@FreeBSD.ORG  Tue Nov  6 10:27:44 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 23BD06D6;
 Tue,  6 Nov 2012 10:27:44 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id D2B4C8FC0C;
 Tue,  6 Nov 2012 10:27:42 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA18750;
 Tue, 06 Nov 2012 12:27:41 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1TVgNg-000CfO-Mh; Tue, 06 Nov 2012 12:27:40 +0200
Message-ID: <5098E619.3070902@FreeBSD.org>
Date: Tue, 06 Nov 2012 12:27:37 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:16.0) Gecko/20121030 Thunderbird/16.0.2
MIME-Version: 1.0
To: Gerald Pfeifer <gerald@FreeBSD.org>
Subject: Re: svn commit: r307045 - head/Mk
References: <201211060023.qA60NhFW028290@svn.freebsd.org>
X-Enigmail-Version: 1.4.5
Content-Type: text/plain; charset=X-VIET-VPS
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org,
 ports-committers@FreeBSD.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Nov 2012 10:27:44 -0000

Gerald Pfeifer said:
> Author: gerald
> Date: Tue Nov  6 00:23:43 2012
> New Revision: 307045
> URL: http://svnweb.freebsd.org/changeset/ports/307045
> 
> Log:
>   In addition to CFLAGS and LDFLAGS now also CXXFLAGS set an rpath to
>   the GCC run-time.
>   
>   This extends revision r246991 (2010-01-02) and should not be necessary
>   in most cases since LDFLAGS already covers linking, but one can always

Rather than adding this flag to CXXFLAGS why not drop it from CFLAGS?
There is no place for linker options in compilation flags.

>   compile and link in one swoop, and this makes things consistent between
>   C and C++.

This is a strange argument.  When one does compilation and linking in one swoop
one uses both CFLAGS/CXXFLAGS and LDFLAGS.  In non-broken software there is
never a dependency on linker flags auto-magically appearing in CFLAGS/CXXFLAGS.

Besides, as we discussed before, -Wl in CFLAGS/CXXFLAGS breaks header
pre-compilation with GCC.  So I was surprised to see this commit.

>   Feature safe:	yes
> 
> Modified:
>   head/Mk/bsd.gcc.mk
> 
> Modified: head/Mk/bsd.gcc.mk
> ==============================================================================
> --- head/Mk/bsd.gcc.mk	Mon Nov  5 22:48:07 2012	(r307044)
> +++ head/Mk/bsd.gcc.mk	Tue Nov  6 00:23:43 2012	(r307045)
> @@ -202,6 +202,7 @@ CPP:=			cpp${V}
>  .   if ${_USE_GCC} != 3.4
>  _GCC_RUNTIME:=		${LOCALBASE}/lib/gcc${V}
>  CFLAGS+=		-Wl,-rpath=${_GCC_RUNTIME}
> +CXXFLAGS+=		-Wl,-rpath=${_GCC_RUNTIME}
>  LDFLAGS+=		-Wl,-rpath=${_GCC_RUNTIME}
>  .    if defined (USE_FORTRAN)
>  .    if ${USE_FORTRAN} == yes

-- 
Andriy Gapon