From owner-freebsd-current@FreeBSD.ORG  Wed Jul  4 15:16:41 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E79A216A46F;
	Wed,  4 Jul 2007 15:16:41 +0000 (UTC)
	(envelope-from mime@traveller.cz)
Received: from nxm.secservers.com (nxm.secservers.com [89.185.226.22])
	by mx1.freebsd.org (Postfix) with ESMTP id 7B55813C46E;
	Wed,  4 Jul 2007 15:16:41 +0000 (UTC)
	(envelope-from mime@traveller.cz)
Received: from [127.0.0.1] (nxm.secservers.com. [89.185.226.22])
	by nxm.secservers.com (8.13.4/8.13.8) with ESMTP id l64FGdsA014214;
	Wed, 4 Jul 2007 17:16:39 +0200 (CEST)
	(envelope-from mime@traveller.cz)
From: Michal Mertl <mime@traveller.cz>
To: "Sean C. Farley" <scf@FreeBSD.org>
In-Reply-To: <20070704101026.O77978@thor.farley.org>
References: <1183557221.1799.16.camel@genius.i.cz>
	<20070704143642.GA31254@nagual.pp.ru>
	<20070704150312.GB31683@nagual.pp.ru>
	<20070704101026.O77978@thor.farley.org>
Content-Type: text/plain
Date: Wed, 04 Jul 2007 17:16:37 +0200
Message-Id: <1183562197.1799.23.camel@genius.i.cz>
Mime-Version: 1.0
X-Mailer: Evolution 2.10.2 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
Cc: Andrey Chernov <ache@nagual.pp.ru>,
	freebsd-current <freebsd-current@FreeBSD.org>
Subject: Re: Environment handling broken in /bin/sh with changes to
	{get,set,put}env()
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jul 2007 15:16:42 -0000

Sean C. Farley wrote:
> On Wed, 4 Jul 2007, Andrey Chernov wrote:
> 
> > On Wed, Jul 04, 2007 at 06:36:42PM +0400, Andrey Chernov wrote:
> >> 2) "s" may point to getenv()-provided value there. So just modifying
> >> it directly followed by setenv() call will make things inconsistent.
> >>
> >> 3) In my version of patch there was savestr() which copy arg to avoid
> >> this situation.
> >>
> >> Fix will be to restore var.c to mine variant 1.34
> >
> > You may also try this patch against var.c 1.36:
> 
> Andrey, thank you.
> 
> Sorry for the bug everyone.  Here is a patch that should fix it:
> http://www.farley.org/freebsd/tmp/setenv/sh.patch
> 
> Sean

Both version of a patch fix the regression, thanks.

Michal