From nobody Tue Mar 31 09:55:17 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4flNlT6vqZz6WcTr for ; Tue, 31 Mar 2026 09:55:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4flNlT4px1z3kVy for ; Tue, 31 Mar 2026 09:55:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774950917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L89Do0yscMFW3gAChekiHaEOLiKRP8rH5ATo+oHY4cc=; b=qxsUl/05cTBbNQkHiIRDAEYTaYaO2fI0KlJFBvhC/QqLgOyTUDBGbxNAnLQL1Zc5dT53m6 ddgqXR30eVWBglIsGYjfdfDSfyJteinnLPURmlQITjfArcDmd89YXhE6MnwEVQqeEmhH9/ bWkeYS0TvcQLnUFqFmyKAeP3f0u6AhcWfDGra1urwmkKLO1xML8H8weS7U7IPf+RdXdcDu BxzG+RFPaIGCVVIdjo5ToWCgvRpvpY2guYy14wn9nqd+2c8G1q91YppsxPikxvxVkyRkhl 7KKuKmRqX6zWIuvGdynw+7mqMT5GbaNDRYuexw5s49yE5m5HD/DGJgaQ8aTJ2g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774950917; a=rsa-sha256; cv=none; b=Mt5oTzWdPwkXp0uE4eF8Af6KCbaPXRhOHemVB1Lsc/EdfdWPSfQ8fZM1QDXU5GkrTzz3mg nOS6I83jYDYEv8dZJgiNc/bvLzRmhP3B7qyyC99AZe0M40pqrQIWZD/zxjROZEQNcg+ESH LnQlsyc11q0DamRBKfaxRF4pFcjixBV2YmaEfsJh21kYEBevBe506e4gUmhDw7mEcMGXQd svvzHde+APJnWhbGA0068Om56vY10W9mzi9V6Q8sxgbSHs8AHrkatMHy9sylMgVQhwfGTN S6OYlJvn0+HdzjlX5Sh83wMxr9t8Y3h6OxU22Xb1DpEl40KFSStReshv4A8PUA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774950917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L89Do0yscMFW3gAChekiHaEOLiKRP8rH5ATo+oHY4cc=; b=xhAJ6rNUdn/DL8GPstkd7r/L7hviCAyVLrNDQkQWThA2C4UbEtBLb5kQq2ZB+uJAMW0ino xuz4uZpXl7hxLtZ/cFwKAJ0wtxETDLAhctH/3ZZqw3nKras+qqxtVsfZ/gpzXnw6q6TiDM VlfFNh/R4mVMt7g8oRSAzkuD4SASQ4Qe9qzRFTkIqpPloAtltz98LrmIUXfaan8tYtVxWY ssY3al6TNqAPUiLy1CbeGXw/Sp9LBKH8NyQRfRnB5aJqYAGJyrtJ+4XRe5lL8TmCwdkdVQ snTc6BBQXQcQQ349N/6/jkKN7WGgTIC1KlUmjkBvYM2ScYrcMgxxXzG3pL0hcw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4flNlT42j5z8Hg for ; Tue, 31 Mar 2026 09:55:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c82a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 31 Mar 2026 09:55:17 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: d89987b786a8 - stable/15 - sound: Address some XXX comments regarding AC'97 IDs List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: d89987b786a81ecde0d8cf247bb0d571892bfb54 Auto-Submitted: auto-generated Date: Tue, 31 Mar 2026 09:55:17 +0000 Message-Id: <69cb9a05.3c82a.59c5c4c8@gitrepo.freebsd.org> The branch stable/15 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=d89987b786a81ecde0d8cf247bb0d571892bfb54 commit d89987b786a81ecde0d8cf247bb0d571892bfb54 Author: Christos Margiolis AuthorDate: 2026-03-24 10:32:31 +0000 Commit: Christos Margiolis CommitDate: 2026-03-31 09:54:44 +0000 sound: Address some XXX comments regarding AC'97 IDs These seem harmless to address. Not sure why the original author did not just assign the appropriate names if he knew they were wrong. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D56044 (cherry picked from commit edad981e1e8673b6dd14656fe75b9f239fb777ce) --- sys/dev/sound/pcm/ac97.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/sys/dev/sound/pcm/ac97.c b/sys/dev/sound/pcm/ac97.c index 14ff2f6a62ab..85f1f7ccf4d0 100644 --- a/sys/dev/sound/pcm/ac97.c +++ b/sys/dev/sound/pcm/ac97.c @@ -125,12 +125,7 @@ static const struct ac97_vendorid ac97vendorid[] = { { 0x57454300, "Winbond" }, { 0x574d4c00, "Wolfson" }, { 0x594d4800, "Yamaha" }, - /* - * XXX This is a fluke, really! The real vendor - * should be SigmaTel, not this! This should be - * removed someday! - */ - { 0x01408300, "Creative" }, + { 0x01408300, "SigmaTel" }, { 0x00000000, NULL } }; @@ -238,12 +233,7 @@ static struct ac97_codecid ac97codecid[] = { { 0x594d4800, 0x00, 0, "YMF743", 0 }, { 0x594d4802, 0x00, 0, "YMF752", 0 }, { 0x594d4803, 0x00, 0, "YMF753", 0 }, - /* - * XXX This is a fluke, really! The real codec - * should be STAC9704, not this! This should be - * removed someday! - */ - { 0x01408384, 0x00, 0, "EV1938", 0 }, + { 0x01408384, 0x00, 0, "STAC9704", 0 }, { 0, 0, 0, NULL, 0 } };