From owner-freebsd-stable@FreeBSD.ORG  Wed Jan 23 15:47:22 2008
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E7F1716A417
	for <freebsd-stable@freebsd.org>; Wed, 23 Jan 2008 15:47:22 +0000 (UTC)
	(envelope-from vivek@khera.org)
Received: from yertle.kcilink.com (thingy.kcilink.com [74.92.149.59])
	by mx1.freebsd.org (Postfix) with ESMTP id BA44613C457
	for <freebsd-stable@freebsd.org>; Wed, 23 Jan 2008 15:47:22 +0000 (UTC)
	(envelope-from vivek@khera.org)
Received: from host-121.int.kcilink.com (host-121.int.kcilink.com
	[192.168.7.121])
	by yertle.kcilink.com (Postfix) with ESMTP id E8616C943A
	for <freebsd-stable@freebsd.org>; Wed, 23 Jan 2008 10:47:21 -0500 (EST)
Message-Id: <6BA87BDA-FFAC-4329-B720-98666204FB3F@khera.org>
From: Vivek Khera <vivek@khera.org>
To: FreeBSD Stable List <freebsd-stable@freebsd.org>
In-Reply-To: <200801230924.37310.jhb@freebsd.org>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v915)
Date: Wed, 23 Jan 2008 10:47:21 -0500
References: <47949811.1080505@raad.tartu.ee> <479501BE.4040309@FreeBSD.org>
	<99B0737B-9876-4D86-A9DC-FB5FAD21CB21@kcilink.com>
	<200801230924.37310.jhb@freebsd.org>
X-Mailer: Apple Mail (2.915)
Subject: Re: NO_ knobs in /etc/make.conf
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jan 2008 15:47:23 -0000


On Jan 23, 2008, at 9:24 AM, John Baldwin wrote:

>> What was broken that required this to be "fixed"?
>
> Inconsistent use of what NO_FOO= meant.  Some places only checked if  
> it
> was set, other places required it to be set to "yes", so NO_FOO=no
> might disable FOO or it might not.  The WITHOUT_* / WITH_* scheme was

I guess I wasn't clear about my confusion. What was broken about  
putting all this in make.conf that necessitated a src.conf file too?

Having the names consistent is great, though.