From owner-freebsd-current Thu Sep 12 1: 5:33 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90F6237B400; Thu, 12 Sep 2002 01:05:31 -0700 (PDT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DEAC43E6E; Thu, 12 Sep 2002 01:05:31 -0700 (PDT) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id 2F077AE160; Thu, 12 Sep 2002 01:05:31 -0700 (PDT) Date: Thu, 12 Sep 2002 01:05:31 -0700 From: Maxime Henrion To: Maxim Sobolev Cc: current@FreeBSD.org Subject: Re: Panic during reboot in vflush() Message-ID: <20020912080531.GQ86074@elvis.mu.org> References: <3D8045D3.35A3DECE@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D8045D3.35A3DECE@FreeBSD.org> User-Agent: Mutt/1.3.27i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Maxim Sobolev wrote: > Any ideas? Looks like some other processes was modifying the mountlist while vfs_unmountall() was running. Is this an SMP box ? It would be nice if you could check in gdb which other process was holding the mountlist_mtx mutex if any. The vfs_unmountall() function doesn't acquire the mounstlist_mtx and states this is OK in a comment because this functions is ran upon reboot, but I suspect this is incorrect and we still need to do the locking. I'll write a patch tonight to add locking into vfs_unmountall(), but it may be hard to test unless you know of a way to reproduce this panic easily. Cheers, Maxime To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message