From nobody Tue Feb 4 21:21:26 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YnbsH5sXtz5mTfK; Tue, 04 Feb 2025 21:21:39 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YnbsH1JvYz3dMR; Tue, 04 Feb 2025 21:21:39 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-844ee166150so146072639f.2; Tue, 04 Feb 2025 13:21:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738704098; x=1739308898; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cKTbr4OKmirNekRDXI5irE9C1ROaqTbCbVCjPTIYFUo=; b=ekwlSEXj4s8hyU8U6tydepYKKIOeoaySDbgcuuc4tvQ2egQ220L7tosHR3/geI9OM/ na6SPISAKrb1bGlaasMQ00ohuQYFATPHpiDcKZV3vcjyN7h/Hu1kXqfbxuCR20muVy7j Es2DAQADebYW6hS6w9mRWM0rCVaFx8SvL2m5XJ0pMgnTMRx7g1PE2sXEDsljjGRlywNH LUSbvJJPg1z83cU8UUo42PcRrsSr7bsLCaX7FRvBfdp9Ixf/lIGPLcIvF8p76/Wl+M/g OyKeDoMJVE5QPrb7wM302v5hjfsejAsNXv7Y21DA9MM2I3v6cRAxWXBd/D/VM+OgCBUM o2zg== X-Forwarded-Encrypted: i=1; AJvYcCUC4RiUndt9pjg/27oYSwSZ3szAQjYJ8/LFFe6oBOt7+pnJHeJQoEjcuol//UdMFlb2Mq/So/x8Fd1xBayxVYDt6tqY@freebsd.org, AJvYcCUNMB6hZhOYNHCuZ5MbXBuER9nSHwUjYYy7pezlY/Nin85biWgFzRwafZP4Oal97EdJWSkPFhj2rqBqpyA2i6Q=@freebsd.org, AJvYcCV7xs/6k1a5FZznEQHh43sLrsMAotJfLnvTqWBmDIBCP+vk58lYrEQEDfCg8f+kGAttdu9iup80o7DQTLiH9D4PAlKqHJ4=@freebsd.org X-Gm-Message-State: AOJu0Yxe66QB/9aJCR10G64Wl7aqK5/jz3BRNN8G9x6y5J7AdPN8M82I hUMMgxp2zOo0qs6fky4wtcSM8LlNwrwOWmcCCKeXIwObiL9U+lvjhM1/VXHjvcFDRBNWItt8np/ QV3R9x2FCpvlesOE97Pv1vhfzDLHJNw== X-Gm-Gg: ASbGncvTyvE9MF8kGG22kEA5UTE80GThD1SlOAcOPwgqLdT1tYr364iKJRIAXO4lfys pVk8z1rLfMlXt8i8UTdUZijO3QhLFFd3VlHPqVJ2mRNky+HmnQpOoTrSy4DqC971Xxn53TEKov1 oRNX0GAzVQAXST179FnS1GEW27RDb1gQE= X-Google-Smtp-Source: AGHT+IG4V9ak9THAKkGFT7CJFGJL/gloZyKCKpU919s/khpf0qAj+N7cLgnL9Ujv4Mtlc9OAYt6rKYGHo0jw+XC50V4= X-Received: by 2002:a05:6602:4084:b0:843:e9c1:9317 with SMTP id ca18e2360f4ac-854ea531346mr58429039f.14.1738704098053; Tue, 04 Feb 2025 13:21:38 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202502041658.514Gwo4I049201@gitrepo.freebsd.org> <20250204171121.8EA2C281@slippy.cwsent.com> In-Reply-To: From: Ed Maste Date: Tue, 4 Feb 2025 16:21:26 -0500 X-Gm-Features: AWEUYZndDOnlXLAVCToW9PxfQMSrYmC8VqwcUFpuf6WyobHe14ddwn-1bcdYV7Y Message-ID: Subject: Re: git: ecccb638d494 - main - mountd: Promote missing netmask log to LOG_ERR To: Rick Macklem Cc: Cy Schubert , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [2.51 / 15.00]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-0.999]; NEURAL_SPAM_MEDIUM(0.96)[0.962]; NEURAL_SPAM_SHORT(0.94)[0.942]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_IN_DNSWL_NONE(0.00)[209.85.166.42:from]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ONE(0.00)[1]; RCPT_COUNT_FIVE(0.00)[5]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; R_DKIM_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; TAGGED_RCPT(0.00)[]; RBL_SENDERSCORE_REPUT_8(0.00)[209.85.166.42:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.166.42:from]; FREEFALL_USER(0.00)[carpeddiem]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com] X-Spamd-Bar: ++ X-Rspamd-Queue-Id: 4YnbsH1JvYz3dMR > > Should this be changed from WARNING to ERROR too? > I don't have a strong opinion, but I would say no. > An error in mountd indicates a failure and in this case the semantics > remain what they have always been and doesn't necessarily imply > a semantics failure. I agree with Rick. I wasn't sure about this at first, but noticed that there are some "Warning:" syslogs at LOG_ERR priority already.