Date: Tue, 12 Apr 2005 23:05:05 -0700 From: John-Mark Gurney <gurney_j@resnet.uoregon.edu> To: Suleiman Souhlal <ssouhlal@FreeBSD.org>, current@FreeBSD.org Subject: Re: [PATCH] Allow watching of vnodes that reside on non-UFS filesystems with kqueue Message-ID: <20050413060505.GM56487@funkthat.com> In-Reply-To: <20050413054020.GL56487@funkthat.com> References: <0842a01b5aa0cfcd84763fff4a30113e@FreeBSD.org> <20050413054020.GL56487@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
John-Mark Gurney wrote this message on Tue, Apr 12, 2005 at 22:40 -0700: > Suleiman Souhlal wrote this message on Tue, Apr 12, 2005 at 23:05 -0400: > > The patch at > > http://people.freebsd.org/~ssouhlal/testing/kqueue-hooks-20050412.diff > > allows watching vnodes on non-UFS filesystems with kqueue. > > > > It moves the VN_KNOTE calls to pre and post VOP_* hooks. These hooks > > are currently used for VFS lock debugging only, but I made them > > unconditional. I think that they we could eventually move the > > mac_check_vnode_* calls into them too, with a bit of work. > > > > I would like to commit this to HEAD, if there are no objections. > > I would prefer to move the vfs_kqfilter and filt_vfs* functions either > be moved to a vfs specific file, or be moved to their own file.. also, > it appears that we lost support for extending of files... though I can't > confirm that... Have you verified that extending still gets notified? > > Other wise looks good... Just to clarify, I'm only ok'ing the kqueue changes (as long as the concers above are cleared).. I don't have enough VFS experience to say how the VFS changes will effect things.. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050413060505.GM56487>