From owner-p4-projects@FreeBSD.ORG  Thu Dec  3 15:57:27 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1EBEF1065676; Thu,  3 Dec 2009 15:57:27 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D6B68106566C;
	Thu,  3 Dec 2009 15:57:26 +0000 (UTC)
	(envelope-from nwhitehorn@freebsd.org)
Received: from mail.icecube.wisc.edu (trout.icecube.wisc.edu [128.104.255.119])
	by mx1.freebsd.org (Postfix) with ESMTP id 6A1728FC08;
	Thu,  3 Dec 2009 15:57:26 +0000 (UTC)
Received: from localhost (localhost.localdomain [127.0.0.1])
	by mail.icecube.wisc.edu (Postfix) with ESMTP id D5F24582A7;
	Thu,  3 Dec 2009 09:57:25 -0600 (CST)
X-Virus-Scanned: amavisd-new at icecube.wisc.edu
Received: from mail.icecube.wisc.edu ([127.0.0.1])
	by localhost (trout.icecube.wisc.edu [127.0.0.1]) (amavisd-new,
	port 10030)
	with ESMTP id Jvs9oJO3zpNf; Thu,  3 Dec 2009 09:57:25 -0600 (CST)
Received: from elpis.tachypleus.net (i3-dhcp-172-16-223-177.icecube.wisc.edu
	[172.16.223.177])
	by mail.icecube.wisc.edu (Postfix) with ESMTP id 15C84582A4;
	Thu,  3 Dec 2009 09:57:25 -0600 (CST)
Message-ID: <4B17DFEA.1020704@freebsd.org>
Date: Thu, 03 Dec 2009 09:57:30 -0600
From: Nathan Whitehorn <nwhitehorn@freebsd.org>
User-Agent: Thunderbird 2.0.0.23 (X11/20091130)
MIME-Version: 1.0
To: Alexander Motin <mav@FreeBSD.org>
References: <200912031546.nB3Fksxc047234@repoman.freebsd.org>
In-Reply-To: <200912031546.nB3Fksxc047234@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 171334 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2009 15:57:27 -0000

Alexander Motin wrote:
> http://p4web.freebsd.org/chv.cgi?CH=171334
>
> Change 171334 by mav@mav_mavbook on 2009/12/03 15:46:47
>
> 	Migrate powerpc ATA controllers to the new world order.
> 	Submitted by:	nwitehorn@
>
> Affected files ...
>
> .. //depot/projects/scottl-camlock/src/sys/powerpc/powermac/ata_dbdma.c#2 edit
> .. //depot/projects/scottl-camlock/src/sys/powerpc/powermac/ata_kauai.c#7 edit
> .. //depot/projects/scottl-camlock/src/sys/powerpc/powermac/ata_macio.c#6 edit
> .. //depot/projects/scottl-camlock/src/sys/powerpc/psim/ata_iobus.c#6 edit
>
> Differences ...
>
> ==== //depot/projects/scottl-camlock/src/sys/powerpc/powermac/ata_dbdma.c#2 (text+ko) ====
>
> @@ -230,7 +229,7 @@
>  		return EIO;
>  	}
>  
> -	request->dma = &ch->dma.slot[atadev->unit];
> +	request->dma = &ch->dma.slot[0];
>  
>  	if ((error = bus_dmamap_load(request->dma->data_tag, 
>  	    request->dma->data_map, request->data, request->bytecount,
>   
I made an error in this part of the patch -- it should be request->unit, 
not 0, here. Thanks for your work!
-Nathan