From owner-freebsd-current@FreeBSD.ORG Wed Nov 2 15:17:03 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9714C16A41F for ; Wed, 2 Nov 2005 15:17:03 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail5.speedfactory.net [66.23.216.218]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2797F43D7F for ; Wed, 2 Nov 2005 15:16:50 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 1239540 for multiple; Wed, 02 Nov 2005 10:14:50 -0500 Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id jA2FGaGi057602; Wed, 2 Nov 2005 10:16:43 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-current@freebsd.org Date: Wed, 2 Nov 2005 10:10:30 -0500 User-Agent: KMail/1.8.2 References: <200511020044.jA20ibXV041464@ambrisko.com> In-Reply-To: <200511020044.jA20ibXV041464@ambrisko.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200511021010.31248.jhb@freebsd.org> X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=100 Cc: Subject: Re: Rocket Port update patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2005 15:17:03 -0000 On Tuesday 01 November 2005 07:44 pm, Doug Ambrisko wrote: > Scott Long writes: > | Doug Ambrisko wrote: > | > I've brought in the changes to the driver from the Comtrol web site. > | > This greatly improves the RocketPort HW support for those devices. > | > The changes are at: > | > http://www.ambrisko.com/doug/rp_current.patch > | > > | > I'd like to commit it so things just work out of the box. I tried to > | > maintain all the various FreeBSD & Comtrol changes. > | > > | > It works here on my previously unsupported card. > | > | One thing stands out on the brief skim. Why on earth does the code need > | to keep a global count of the number of adapters, and why does it bail > | if there are more than 4 adapters? > > I don't know. Do we have a contact there to ask questions? I don't have > more then one 16 port adapter to see if there is a problem. > > That brings up a point, we need to scope the functions and stuff so > they don't conflict with other stuff. I kind-of hate to change > all the names to make it easier to merge in changes later. > Should we change all the sFlushRxFIFO type stuff to rp_s_flush_rx_fifo > and put the globals into the softc's? Obviously they've put some > effort into supporting FreeBSD which is a good thing. I don't know > how things go between them and us. It seems odd that they want to use explicit bzero() rather than M_ZERO as well. Is that to support really old versions of FreeBSD that didn't have M_ZERO? (I think that's <= 4.2 or some such). -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org