From nobody Wed Jun 8 07:40:10 2022 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 406038330E9 for ; Wed, 8 Jun 2022 07:40:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LHzf30cYJz4YQL for ; Wed, 8 Jun 2022 07:40:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E9AA836BB for ; Wed, 8 Jun 2022 07:40:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2587eAsr077713 for ; Wed, 8 Jun 2022 07:40:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2587eA3a077712 for net@FreeBSD.org; Wed, 8 Jun 2022 07:40:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 263445] [tcp] Fatal trap 12: page fault while in kernel mode // supervisor read data, page not present // 13.1-RC3 Date: Wed, 08 Jun 2022 07:40:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654674011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Hb9XP1PpLANFkqEWXznMFORyYhkpNo9u54h3xMUtsE=; b=KSvGtH8UijB5ckfZ2PBZvOTST9tjiYZQDpPIWnEv3IFSs93qy9csQ8cbnFCnnlqtdQm9+6 CjtoxyG2m06q5kFho2RoDrV1WwMI13h9QrANEeEopGjWceRttIMIYyWoaoG2ZbnUm50lD8 ZD7ospevRLDKKN7+XaTYs8sM5uwn+PzxpjonXNcxXRoa9XU1ralb9WuvULYwYysBYu0++M aNLXxQh7PzLlTHf2jXH8MjPaSFV4mptFmzi8ViVRmL3YVVkkhw6G+dXosXm43i3UWko9Ij b7ZHTR8kS4UGjcWz0kECWNXgjEuWYRbimZDCoWLxc3FAf57eOvUlkcY+9NWvxg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654674011; a=rsa-sha256; cv=none; b=Kc6dX6tjmxgtY+Dscu/FoOh6IOxsGgymNzNE31fNl1cFFtWrWQ7vtpVQF9XJGBFE/eTeoS muA5gPDUYjKCD6hjwPO1w9AmlniyocGPV/mIdLaqfFA80z59bXC+D3I4mOxopxROnMs4S9 5VyWTHakAVpRg3JJo2ZF4ZoYWvU/7C0TiU2cDLI+Qf22WdrmxHv+oXbBaTOLDT/uxdbwiR XlKfpqjWj0aUB1NF1n99PvNiZXDux2N5AhcvPvAsqq1O42pbln0SIBQXrBOXfd4zziqWW6 CB1OjXBDc6q9ROioIaaBXIbxGwLd8rKQfEC/ChMMBpn1876Ix1MFHGlLQUFpsA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263445 --- Comment #21 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dce2525c8108a830d08d75771621d1bc58= 0edd82c commit ce2525c8108a830d08d75771621d1bc580edd82c Author: Richard Scheffenegger AuthorDate: 2022-06-08 07:14:16 +0000 Commit: Richard Scheffenegger CommitDate: 2022-06-08 07:18:32 +0000 tcp: remove goto and address another NULL deref in SACK Missed another NULL dereference during KASSERTS after traversing the scoreboard. While at it, scratch the goto by making the traversal conditional, and remove duplicate checks using an unconditional loop with all checks inside. Reviewed By: hselasky PR: 263445 MFC after: 1 week Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D35428 sys/netinet/tcp_sack.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=