From owner-svn-src-head@FreeBSD.ORG Thu Mar 26 02:14:31 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 849F4106564A; Thu, 26 Mar 2009 02:14:31 +0000 (UTC) (envelope-from weongyo.jeong@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.230]) by mx1.freebsd.org (Postfix) with ESMTP id 3B7598FC1A; Thu, 26 Mar 2009 02:14:31 +0000 (UTC) (envelope-from weongyo.jeong@gmail.com) Received: by rv-out-0506.google.com with SMTP id l9so544444rvb.43 for ; Wed, 25 Mar 2009 19:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent:organization :x-operation-sytem; bh=nfd77SMQlC65z+2F088QuBCcDOI4yLBJ4XJJKOP8rus=; b=IkxUrvSF+lCyZEvgac5BUoW9rLWudk7ugpFDBICrjL2arDPfYJAG+fTdWFCFq6r+de kES8gX64TpeL/nX0Va7LQI+uPRrSGSbAy9Jtq+ziEjOvA9cffMDm4xcAGkGVgZaN5JfM fUsnO388jdQmixiOpKYQux4scP4cl4L/whkkI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent :organization:x-operation-sytem; b=Ul40FwajYBnW4DqxXzFxq/vno5eLa6si1zZP9rQBLDzB84mLSUH8OhmivhY5dQ971G bOqB8hnM4oYvAMpXiVkiZ+MZMJjJ1f7ZAVPa6rHPlzm06cIQXqk5c7FTZOUWpvwoBPJP uNpQVFzskOLWMNxMpbayzPCcQXigUMhuP8C/w= Received: by 10.141.211.5 with SMTP id n5mr153498rvq.106.1238033670903; Wed, 25 Mar 2009 19:14:30 -0700 (PDT) Received: from weongyo ([114.111.62.249]) by mx.google.com with ESMTPS id g22sm17171879rvb.33.2009.03.25.19.14.28 (version=SSLv3 cipher=RC4-MD5); Wed, 25 Mar 2009 19:14:30 -0700 (PDT) Received: by weongyo (sSMTP sendmail emulation); Thu, 26 Mar 2009 11:14:26 +0900 From: Weongyo Jeong Date: Thu, 26 Mar 2009 11:14:26 +0900 To: Nathan Whitehorn Message-ID: <20090326021426.GA19018@weongyo.cdnetworks.kr> References: <200903250342.n2P3gnxa064756@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200903250342.n2P3gnxa064756@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i Organization: CDNetworks. X-Operation-Sytem: FreeBSD Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r190403 - head/sys/powerpc/powermac X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Weongyo Jeong List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2009 02:14:32 -0000 On Wed, Mar 25, 2009 at 03:42:49AM +0000, Nathan Whitehorn wrote: > Author: nwhitehorn > Date: Wed Mar 25 03:42:49 2009 > New Revision: 190403 > URL: http://svn.freebsd.org/changeset/base/190403 > > Log: > Disable ATA DMA for ATAPI devices for now. Apparently, certain revisions > of this controller, in combination with certain ATAPI devices and phases > of the moon, will cause DMA operations for ATAPI to fail. > > Modified: > head/sys/powerpc/powermac/ata_macio.c > > Modified: head/sys/powerpc/powermac/ata_macio.c > ============================================================================== > --- head/sys/powerpc/powermac/ata_macio.c Wed Mar 25 03:02:03 2009 (r190402) > +++ head/sys/powerpc/powermac/ata_macio.c Wed Mar 25 03:42:49 2009 (r190403) > @@ -259,6 +259,10 @@ ata_macio_setmode(device_t parent, devic > > mode = ata_limit_mode(dev, mode, sc->max_mode); > > + /* XXX Some controllers don't work correctly with ATAPI DMA */ > + if (atadev->param.config & ATA_PROTO_ATAPI) > + mode = ata_limit_mode(dev, mode, ATA_PIO_MAX); > + > if (ata_controlcmd(dev, ATA_SETFEATURES, ATA_SF_SETXFER, 0, mode)) > return; With this commit my iBook G4 boots successfully without setting `hw.ata.atapi_dma=0'. Thanks! It'd be best if I can use ATAPI DMA soon. regards, Weongyo Jeong