Date: Wed, 22 Sep 2004 09:38:10 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Brian Fundakowski Feldman <green@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c Message-ID: <20040922163810.GA28683@odin.ac.hmc.edu> In-Reply-To: <20040922153007.GA91347@green.homeunix.org> References: <200409220859.i8M8xgwb022928@repoman.freebsd.org> <20040922130052.GA3407@green.homeunix.org> <20040922150105.GA17806@odin.ac.hmc.edu> <20040922153007.GA91347@green.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 22, 2004 at 11:30:07AM -0400, Brian Fundakowski Feldman wrote: > On Wed, Sep 22, 2004 at 08:01:05AM -0700, Brooks Davis wrote: > > On Wed, Sep 22, 2004 at 09:00:52AM -0400, Brian Fundakowski Feldman wro= te: > > > On Wed, Sep 22, 2004 at 08:59:42AM +0000, Brooks Davis wrote: > > > > brooks 2004-09-22 08:59:42 UTC > > > >=20 > > > > FreeBSD src repository > > > >=20 > > > > Modified files: > > > > sys/net if.c=20 > > > > Log: > > > > Fix a LOR where ifconf() used copyout while holding a mutex. Thi= s LOR > > > > was seen when configuring addresses on interfaces using ifconfig.= This > > > > patch has been verified to work with over eight thousand addresses > > > > assigned to an interface. > > > > =20 > > > > LOR id: 031 > > >=20 > > > You really need to be running with INVARIANTS if you plan on committi= ng > > > kernel code, or people are likely to get angry when their systems cra= sh > > > for stupid reasons. > >=20 > > Sorry about that. Pass the pointy had please. :-( >=20 > No hard feelings, since I'm used to having a new issue or two every kernel > upgrade, but this really should be a lesson to anyone listening that kern= el > development without INVARIANTS (and sometimes WITNESS) is a big no-no. Yah, I've added INVARIANTS back to my laptop kernel in perforce to avoid this particular mistake in the future. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBUapyXY6L6fI4GtQRAh5nAJwMPDtO1xpn6DuJQxnywSqmQLWcgQCgvT9A 2M2XIujYwD1HcsxJqkJ67Jc= =lf9X -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040922163810.GA28683>