From owner-cvs-all Mon Sep 3 22:55:20 2001 Delivered-To: cvs-all@freebsd.org Received: from peter3.wemm.org (c1315225-a.plstn1.sfba.home.com [24.14.150.180]) by hub.freebsd.org (Postfix) with ESMTP id 66A7C37B40B; Mon, 3 Sep 2001 22:55:10 -0700 (PDT) Received: from overcee.netplex.com.au (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id f845tAM35929; Mon, 3 Sep 2001 22:55:10 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 050A4380C; Mon, 3 Sep 2001 22:55:10 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: John Baldwin Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_shutdown.c In-Reply-To: Date: Mon, 03 Sep 2001 22:55:10 -0700 From: Peter Wemm Message-Id: <20010904055510.050A4380C@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG John Baldwin wrote: > > On 02-Sep-01 Peter Wemm wrote: > > peter 2001/09/02 05:24:38 PDT > > > > Modified files: > > sys/kern kern_shutdown.c > > Log: > > The !RESTARTABLE_PANICS code has some loose ends. > > What is holding_giant for? Oh, and you do know that you are truly evil > incarnate now, right? I'm not sure. Matt added it in rev 1.107, but the code that sets it is #if 0'ed out. It is a real mess. The other part of the diff was an accident that leaked from a local change. I've been meaning to back it out but just couldn't quite do it. Ian Dowse flagged it yesterday evening I think. I am amused at how few people had noticed it, and of those most had read the diff. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message