From owner-svn-src-head@freebsd.org Wed Jul 22 04:26:05 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A93C19A721C; Wed, 22 Jul 2015 04:26:05 +0000 (UTC) (envelope-from loos.br@gmail.com) Received: from mail-lb0-x22f.google.com (mail-lb0-x22f.google.com [IPv6:2a00:1450:4010:c04::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 29B4F1127; Wed, 22 Jul 2015 04:26:05 +0000 (UTC) (envelope-from loos.br@gmail.com) Received: by lbbyj8 with SMTP id yj8so128785564lbb.0; Tue, 21 Jul 2015 21:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=CR8sEmwLaFP3G574isfleMIaIzVckovYp/D4aunNLbc=; b=YFE4LQIAc6bpsgaqx7zjIgoSCBPgkGgD1agB1z93rR2M7UaZ5WPxI53haGS8RyQ0nv ktN5dBNbTQsyhrV+OSCBehHKIiesaUeRZSuLxeiOYQLSBOhfdzFjC94SmMmdtSsBZi+b f/GTXxQdGEOSOQJwPx5nbbGhC+FiBfvmmGy0X5iRmaYhX6Nkhlcl56If4AGLpFqKj5DC gg0R/ZLU3+0fw/f6UXCSe56q10uv+SWZUK4wg4IccEF9WUFyRHhMgRo+k+PFn48YUSoL v2XFRgPhD5+GvuoW2/OMHsqHM7gcv4LhNBaa0wb9rAwGLSQuc73r2/3mocSZsx1cbAuk 86Ug== MIME-Version: 1.0 X-Received: by 10.152.10.97 with SMTP id h1mr391777lab.45.1437539162932; Tue, 21 Jul 2015 21:26:02 -0700 (PDT) Received: by 10.152.112.170 with HTTP; Tue, 21 Jul 2015 21:26:02 -0700 (PDT) In-Reply-To: <201507212033.t6LKXbTj041660@repo.freebsd.org> References: <201507212033.t6LKXbTj041660@repo.freebsd.org> Date: Wed, 22 Jul 2015 01:26:02 -0300 Message-ID: Subject: Re: svn commit: r285766 - in head/sys: conf dev/vt dev/vt/logo From: Luiz Otavio O Souza To: "Conrad E. Meyer" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2015 04:26:05 -0000 On Tue, Jul 21, 2015 at 5:33 PM, Conrad E. Meyer wrote: > Author: cem > Date: Tue Jul 21 20:33:36 2015 > New Revision: 285766 > URL: https://svnweb.freebsd.org/changeset/base/285766 > > Log: > vt: Draw logos per CPU core > > This feature is inspired by another Unix-alike OS commonly found on > airplane headrests. > > A number of beasties[0] are drawn at top of framebuffer during boot, > based on the number of active SMP CPUs[1]. Console buffer output > continues to scroll in the screen area below beastie(s)[2]. > > After some time[3] has passed, the beasties are erased leaving the > entire terminal for use. > > Includes two 80x80 vga16 beastie graphics and an 80x80 vga16 orb > graphic. (The graphics are RLE compressed to save some space -- 3x 3200 > bytes uncompressed, or 4208 compressed.) > > [0]: The user may select the style of beastie with > > kern.vt.splash_cpu_style=(0|1|2) > > [1]: Or the number may be overridden with tunable kern.vt.splash_ncpu. > [2]: https://www.youtube.com/watch?v=UP2jizfr3_o > [3]: Configurable with kern.vt.splash_cpu_duration (seconds, def. 10). > > Differential Revision: https://reviews.freebsd.org/D2181 > Reviewed by: dumbbell, emaste > Approved by: markj (mentor) > MFC after: 2 weeks > > Added: > head/sys/dev/vt/logo/logo_beastie.c (contents, props changed) > head/sys/dev/vt/vt_cpulogos.c (contents, props changed) > Modified: > head/sys/conf/files > head/sys/dev/vt/vt.h > head/sys/dev/vt/vt_core.c > > Modified: head/sys/conf/files > ============================================================================== > --- head/sys/conf/files Tue Jul 21 20:30:06 2015 (r285765) > +++ head/sys/conf/files Tue Jul 21 20:33:36 2015 (r285766) > @@ -2726,9 +2726,11 @@ dev/vt/hw/efifb/efifb.c optional vt_efi > dev/vt/hw/fb/vt_fb.c optional vt > dev/vt/hw/vga/vt_vga.c optional vt vt_vga > dev/vt/logo/logo_freebsd.c optional vt splash > +dev/vt/logo/logo_beastie.c optional vt splash > dev/vt/vt_buf.c optional vt > dev/vt/vt_consolectl.c optional vt > dev/vt/vt_core.c optional vt > +dev/vt/vt_cpulogos.c optional vt splash > dev/vt/vt_font.c optional vt > dev/vt/vt_sysmouse.c optional vt > dev/vte/if_vte.c optional vte pci [...] Hi, This seems to break kernels without 'device splash'. One example is the Raspberry Pi kernel: MAKE=make sh /usr/src/sys/conf/newvers.sh RPI-B cc -c -O -pipe -mfloat-abi=softfp -g -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/libfdt -I/usr/src/sys/gnu/dts/include -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -mcpu=arm1176jzf-s -funwind-tables -ffreestanding -fwrapv -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -mfpu=none -std=iso9899:1999 -Werror vers.c linking kernel.debug vt_core.o: In function `vtterm_cnprobe': /usr/src/sys/dev/vt/vt_core.c:1363: undefined reference to `vt_logo_sprite_height' vt_core.o: In function `vt_termsize': /usr/src/sys/dev/vt/vt_core.c:568: undefined reference to `vt_logo_sprite_height' vt_core.o: In function `vt_winsize': /usr/src/sys/dev/vt/vt_core.c:603: undefined reference to `vt_logo_sprite_height' vt_core.o: In function `vt_compute_drawable_area': /usr/src/sys/dev/vt/vt_core.c:642: undefined reference to `vt_logo_sprite_height' vt_core.o: In function `vt_mouse_event': /usr/src/sys/dev/vt/vt_core.c:1955: undefined reference to `vt_logo_sprite_height' vt_core.o:/usr/src/sys/dev/vt/vt_core.c:2632: more undefined references to `vt_logo_sprite_height' follow vt_core.o: In function `vt_flush': /usr/src/sys/dev/vt/vt_core.c:1213: undefined reference to `vtterm_draw_cpu_logos' /usr/src/sys/dev/vt/vt_core.c:1222: undefined reference to `vt_logo_sprite_height' vt_core.o: In function `vt_scrollmode_kbdevent': /usr/src/sys/dev/vt/vt_core.c:766: undefined reference to `vt_logo_sprite_height' *** [kernel.debug] Error code 1 make[2]: stopped in /usr/obj/arm.armv6/usr/src/sys/RPI-B 1 error Luiz