From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jun 16 16:54:44 2015 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1161512D for ; Tue, 16 Jun 2015 16:54:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EEB8E30A for ; Tue, 16 Jun 2015 16:54:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5GGshJ7025568 for ; Tue, 16 Jun 2015 16:54:43 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 200245] comms/owfs: Update to 3.1p0 Date: Tue, 16 Jun 2015 16:54:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: johan@stromnet.se X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 16:54:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200245 --- Comment #20 from johan@stromnet.se --- Okay. If I understand correct, the same compilation is done later in post-install anyway, since we have to build with the specific hack from https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-python.html. I did some testing. The optimized files (-O) are not actually built at all, maybe erased somehow? If I add the following... (cd ${STAGEDIR}${PREFIX} \ && ${PYTHON_CMD} -O ${PYTHON_LIBDIR}/compileall.py \ -d ${PYTHONPREFIX_SITELIBDIR} -f ${PYTHONPREFIX_SITELIBDIR:S;${PREFIX}/;;}) ..I get the following errors: Error: Orphaned: %%PYTHON_SITELIBDIR%%/ow/__init__.pyo Error: Orphaned: %%PYTHON_SITELIBDIR%%/ownet/__init__.pyo Error: Orphaned: %%PYTHON_SITELIBDIR%%/ownet/connection.pyo Without the above change (only having @${PYTHON_CMD} -O -m compileall ${WRKSRC}), the .pyo files are never installed and thus never orphaned. My vote is to do the following: * Remove the do-build section python calls * Add the above compileall with the -O flag to post-install * Add .pyo files for each .pyc file in pkg-plist With those changes, it builds fine here, with .pyo files installed. To admin@lissyara.su, could you add those minor changes to the patch you've already created please? Then I think we're good for maintainer-approval. -- You are receiving this mail because: You are the assignee for the bug.