From owner-svn-src-all@freebsd.org Mon Jul 18 20:34:04 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 04C0BB9B3BB for ; Mon, 18 Jul 2016 20:34:04 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C81041AD8 for ; Mon, 18 Jul 2016 20:34:03 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: by mail-it0-x22e.google.com with SMTP id f6so1467472ith.0 for ; Mon, 18 Jul 2016 13:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sippysoft-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=xbNYJEcy0zRGVGRJ4L41t8xBoCLLxUcoXuLYsR5Nr6Y=; b=hxeCnXJi2hjzL7uc3zFJxVgNnsqIJjnlhxDkSQtzeMuqjwD6pjlJdNAnmjaDEG0/Tz rG5GPEONLk4zUDeZgF9IdAtJ5HZn7Ydk5ChM8M87d0sTDmY8SfNUCnvIaEwreCp9O2mc 5Ak6cah2+cqEUGPQZjztFhfDCO94rrnbD6ripnvivv8i417eyvABAqRU6CrnypyK3WC+ 2rYu1r2tn8gSv2WPA9JkED9aIao5PeZUldq4EWH8LbTBAlJ7nn9ma5XMg7doZi/YVIf9 hbKNnQOxDrRrF7YPEyavEbo76KZqBYkomQw4SXncb4dTve9xHW7bM5fuQZFnY/5O1v/i 1b9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=xbNYJEcy0zRGVGRJ4L41t8xBoCLLxUcoXuLYsR5Nr6Y=; b=V+4ZA88m3GZ0G5CCkxnwK2OkzS37CKEFt1sSTIDZ/0rp5x13WRsRqpsMO8hkFVm1rK YyWhlkkWo+k6BhnXTSxtIFn+WUdP5RKN/oB9MQHlNV86zxKDAZzeXJtZZEXn5Kt3pZPe ihPYRjvqFAxxc9+zqw6Y8k/3KDTWFZg2b+EVxBJlXruVkVwFXVbvorfHD+LQHCvMQbOG jP2y/j2SVA8pkPLlcq/5wAxQ+vzbKL71RCvXcEU+U+5F1cUFbGmbQW5sefv9FNjyK+oE I+qnuThDnpLVfSau72p5W/uhwQGkiL1Jrf0/bGUujsr2Vm5Zj6FO/Dp6cOB9nq2qZMph ZyGw== X-Gm-Message-State: ALyK8tISLZArgiIeUiEz9RhKfYR29w+84zuppMA4JiwJ08JqbnRNu/ErE8jjR32l1ePOdfsNUlnfmI/SpUvIb3j2 X-Received: by 10.36.188.65 with SMTP id n62mr51471955ite.61.1468874043060; Mon, 18 Jul 2016 13:34:03 -0700 (PDT) MIME-Version: 1.0 Sender: sobomax@sippysoft.com Received: by 10.36.59.193 with HTTP; Mon, 18 Jul 2016 13:34:02 -0700 (PDT) In-Reply-To: References: <201607180500.u6I501CX063743@repo.freebsd.org> <20ae3dfe-96f4-c897-67d0-71bb94d14858@yandex.ru> <61cba001-2717-49ee-843e-5ed6d18fa17b@yandex.ru> From: Maxim Sobolev Date: Mon, 18 Jul 2016 13:34:02 -0700 X-Google-Sender-Auth: Q1h0YVHaIOFQCYqTp74xxc7Onlg Message-ID: Subject: Re: svn commit: r302985 - head/sys/geom/label To: "Andrey V. Elsukov" , Michael Zhilin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2016 20:34:04 -0000 Andrey, would you mind leaving your comments in the phabricator so that the Mikhail (original contributor of the patch) could work on an improved version? You might be correct about the abs(), I've overlooked that, but the fs_fsize math is just copied over the previous code as far as I can tell. So if it worked with the strict comparison, it should also work with relaxed bound one. https://reviews.freebsd.org/D6208 Thanks! -Max On Mon, Jul 18, 2016 at 1:18 PM, Andrey V. Elsukov wrote: > On 18.07.16 22:37, Maxim Sobolev wrote: > > Well, this looks to me exactly what I am talking about. With this change > > we are only allowing underlying provider to be *slighly* bigger than the > > UFS size. So as I said it's pretty harmless to do so, or at least I > > So, this isn't true. > 1. You use abs() in the macro - it can be less or bigger. > 2. fs_fsize is size of frag blocks, so use it as divider looks incorrect. > > -- > WBR, Andrey V. Elsukov > >