From owner-freebsd-arch@FreeBSD.ORG  Mon Dec  8 17:28:04 2008
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8C2FD106564A
	for <arch@FreeBSD.org>; Mon,  8 Dec 2008 17:28:04 +0000 (UTC)
	(envelope-from marcus@FreeBSD.org)
Received: from creme-brulee.marcuscom.com
	(marcuscom-pt.tunnel.tserv1.fmt.ipv6.he.net
	[IPv6:2001:470:1f00:ffff::1279])
	by mx1.freebsd.org (Postfix) with ESMTP id 190F78FC22
	for <arch@FreeBSD.org>; Mon,  8 Dec 2008 17:28:03 +0000 (UTC)
	(envelope-from marcus@FreeBSD.org)
Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com
	[IPv6:2001:470:1f00:2464::4])
	by creme-brulee.marcuscom.com (8.14.3/8.14.3) with ESMTP id
	mB8HTjdE034314; Mon, 8 Dec 2008 12:29:46 -0500 (EST)
	(envelope-from marcus@FreeBSD.org)
From: Joe Marcus Clarke <marcus@FreeBSD.org>
To: Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?= <des@des.no>
In-Reply-To: <86tz9fynmf.fsf@ds4.des.no>
References: <1228667168.69753.16.camel@shumai.marcuscom.com>
	<86tz9fynmf.fsf@ds4.des.no>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-n0RvummTzj+AenzdrfD+"
Organization: FreeBSD, Inc.
Date: Mon, 08 Dec 2008 12:28:03 -0500
Message-Id: <1228757283.69132.14.camel@shumai.marcuscom.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 FreeBSD GNOME Team Port 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS
	autolearn=ham version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
	creme-brulee.marcuscom.com
Cc: arch@FreeBSD.org
Subject: Re: RFC: New VOP to translate vnode to its component name
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Dec 2008 17:28:04 -0000


--=-n0RvummTzj+AenzdrfD+
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Mon, 2008-12-08 at 11:20 +0100, Dag-Erling Sm=F8rgrav wrote:
> Joe Marcus Clarke <marcus@FreeBSD.org> writes:
> > Here is a patch to HEAD, along with a man page, for VOP_CNP.  VOP_CNP
> > translates a vnode to its component name.  It is currently called from
> > vn_fullpath1() to traverse a vnode hierarchy when cache lookups for
> > those vnodes fail.  I have currently implemented VOP_CNP for devfs and
> > pseudofs.  Kostik has thoroughly reviewed the devfs implementation.  I
> > only recently did the pseudofs implementation at his request.
>=20
> I would prefer pidbuf[PFS_NAMLEN] to pidbuf[11], and you can avoid two
> strlen()s by storing the return value from snprintf().  Also, defining
> pidbuf at the start of the block instead of the start of the function is
> a style(9) violation.  Other than that, the pseudofs part of the patch
> has my approval.

Thanks for the feedback.  This was a section of the pfs code I
especially wanted some comments on.  I'll take care of your suggestions.

Joe

--=20
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome

--=-n0RvummTzj+AenzdrfD+
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEABECAAYFAkk9WSAACgkQb2iPiv4Uz4dFbgCeMyEWYjM2gPN3FtMNaSWI8VuR
Uo4AniLI5atkL0eWolKlxsnx40/S58G+
=4Ndi
-----END PGP SIGNATURE-----

--=-n0RvummTzj+AenzdrfD+--