Date: Mon, 23 Sep 2013 08:58:24 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, nemysis@FreeBSD.org, svn-ports-all@freebsd.org, Boris Samorodov <bsam@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r327791 - in head/graphics/eos-movrec: . files Message-ID: <20130923085824.GA10271@FreeBSD.org> In-Reply-To: <20130923105055.3393e5c0@kalimero.tijl.coosemans.org> References: <201309210613.r8L6Dcqf092555@svn.freebsd.org> <20130923055820.GA62466@FreeBSD.org> <20130923064949.GA79560@FreeBSD.org> <20130923105055.3393e5c0@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 23, 2013 at 10:50:55AM +0200, Tijl Coosemans wrote: > On Mon, 23 Sep 2013 06:49:49 +0000 Alexey Dokuchaev wrote: > > I've just checked on my tindy, it builds fine with my original USE_QT4 > > value. However, it does not package, as pkg-plist was missed in the > > commit. > > It does look excessive. CMakeLists.txt only has: > find_package(Qt4 4.4.2 COMPONENTS QtCore QtGui REQUIRED) Right, same as when I first added it. I honestly do not understand how this USE_QT4 change was committed after few eyes supposedly reviewed it. Not just it contains tons of Qt4 bloat, and does not match find_package(), but apparently no one ever asked themselves, "why a simple movie capture program needs qt4-webkit?". :( ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130923085824.GA10271>