From owner-freebsd-scsi@FreeBSD.ORG Wed Jan 11 12:13:25 2012 Return-Path: Delivered-To: freebsd-scsi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CDADD106566B for ; Wed, 11 Jan 2012 12:13:25 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 0EACA8FC08 for ; Wed, 11 Jan 2012 12:13:24 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id NAA17290; Wed, 11 Jan 2012 13:59:03 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Rkwpb-000Aqw-Fl; Wed, 11 Jan 2012 13:59:03 +0200 Message-ID: <4F0D7986.5080309@FreeBSD.org> Date: Wed, 11 Jan 2012 13:59:02 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: freebsd-scsi@FreeBSD.org X-Enigmail-Version: undefined Content-Type: text/plain; charset=X-VIET-VPS Content-Transfer-Encoding: 7bit Cc: Subject: dadump: missing cam_periph_unlock for the EIO branch? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 12:13:25 -0000 It looks like if the dadump() returns EIO, then it fails to unlock the cam periph lock (the sim lock, really). The leaked lock could lead to unnecessary secondary panics. What do you think? Example: http://sunner.semmy.ru/~az/avg/12.JPG http://sunner.semmy.ru/~az/avg/13.JPG -- Andriy Gapon