From owner-cvs-all@FreeBSD.ORG  Mon Aug  1 14:23:30 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BD7A016A41F;
	Mon,  1 Aug 2005 14:23:30 +0000 (GMT)
	(envelope-from fjoe@neo.samodelkin.net)
Received: from neo.samodelkin.net (samodelkin.net [195.62.0.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CCCC343D5D;
	Mon,  1 Aug 2005 14:23:29 +0000 (GMT)
	(envelope-from fjoe@neo.samodelkin.net)
Received: by neo.samodelkin.net (Postfix, from userid 1000)
	id B8D6C1705F; Mon,  1 Aug 2005 21:23:27 +0700 (NOVST)
Date: Mon, 1 Aug 2005 21:23:27 +0700
From: Max Khon <fjoe@samodelkin.net>
To: Alexander Leidinger <netchild@FreeBSD.org>
Message-ID: <20050801142327.GA71555@samodelkin.net>
References: <200507311046.j6VAktvC055088@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200507311046.j6VAktvC055088@repoman.freebsd.org>
User-Agent: Mutt/1.4.2i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern subr_hints.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Aug 2005 14:23:30 -0000

Hi!

On Sun, Jul 31, 2005 at 10:46:55AM +0000, Alexander Leidinger wrote:

> netchild    2005-07-31 10:46:55 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             subr_hints.c 
>   Log:
>   The resource_xxx routines in subr_hints.c are called before and after the
>   kenv environment in kern_environment.c switches to dynamic kenv. The prior
>   call sets the static variable hintp to the static hints in subr_hints.c
>   (hintmode==0).
>   
>   However, changes to the environment are not detected by the resource_xxx
>   lookups after the change to dynamic kernel environment, so the lookup
>   routines only report the old stuff of hintmode==0, even after the change to
>   the dynamic kenv. This causes kenv users to see a different environment than
>   the kernel routines.
>   
>   This is a problem in the mixer.c code that looks up initial mixer volume
>   settings from the hints: If the hints are dynamic and not from the
>   device.hints file, mixer.c doesn't see them, but kenv does.
>   
>   The patch from the PR (modified to comply to the style of the function)
>   solves this.
>   
>   PR:             83686
>   Submitted by:   Harry Coin <harrycoin@qconline.com>
>   
>   Revision  Changes    Path
>   1.12      +2 -0      src/sys/kern/subr_hints.c

Do you plan to MFC this to RELENG_6?

/fjoe