From nobody Fri Apr 28 01:30:26 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q6w5v12HZz47lBB for ; Fri, 28 Apr 2023 01:30:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q6w5t5y18z3tW2 for ; Fri, 28 Apr 2023 01:30:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682645426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a4jN3Sby9On31Ogn3MLKTobrI7ezAr0TILOrHek1hVs=; b=p8Jq+gtMxQKUtLixh66ytRXzC4XGzd4ZSFXANz6ig9ZttOCfLFwVuhZ5uToBQCjpn0mru5 YS72zu2pa5vV8msKw+NHgEm591T5TdLuQRdRzFTHrVDejuPEl2f8b6dcdS5kSZhx7WKz7i tOBuFcfGbvIKiw3ZXMebf2QQ70xGbxeVuI4BQEIfNAuIYYDqYSVHuU30AtqntPx7ianTgM ayhqhgxDSbMuMcFHcAtj6rY2P72iVSBi3Bfz8ixhWKwLyD7k5+23j89+v11vBwIvKbkNhm OkaGLHnzC8pEvvl6y/fELKs3fGbU5LmEqDR+0cjFfqKGEXIbU3xVk+sNEjAHvg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682645426; a=rsa-sha256; cv=none; b=eeGEFpfKfn+zmETH1E3r4q0AYMsUkZR9lepbuyt9hq1wR3Xc5E868lfL1R3QmtiGcu6u8w jsnE/+mKpTigVXTImI1Uxv/KG4Y+uMMKvcj3AFG0SUq0umHUfaBtzbIsroIdvswG7DJlUI p7FOU4Oj+/k6DUF1flfC2ca0f84hQtZFbYX7DdtqBeArzYAvi1I3rAee6oHWMmgzaPAm74 /lYjZpNHcMB85ccJ/r2ACLgW9Ln58G4l7yJLMTJQGF5Vbofr4flFoz6+LlewAiDwIZtJw3 W4ydAYxBvQWmYDBTHU1VLIfN4sKgr5RZe389fubvAtfKUs3ffXiXZp+bkEy4WQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q6w5t4pDYzgmB for ; Fri, 28 Apr 2023 01:30:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 33S1UQOY096335 for ; Fri, 28 Apr 2023 01:30:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 33S1UQZc096334 for fs@FreeBSD.org; Fri, 28 Apr 2023 01:30:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 270988] vfs: Fix 'emptydir' mount option and vfs_emptydir() Date: Fri, 28 Apr 2023 01:30:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270988 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D6450e7bbad0c68176f28b51773a3af5d6= 022c7dd commit 6450e7bbad0c68176f28b51773a3af5d6022c7dd Author: Olivier Certner AuthorDate: 2023-04-22 16:07:07 +0000 Commit: Konstantin Belousov CommitDate: 2023-04-28 01:27:54 +0000 vfs: Fix "emptydir" mount option Fix vfs_emptydir(). It would consider directories containing directories with name of the form 'X.' (X being any authorized byte) as empty. Also, it would cause VOP_READDIR() to return an error on directories containing enough whiteouts. While here, use a more decently sized buffer as done elsewhere. Remove ad-hoc iteration on the directory's content and instead use the newly exported vn_dir_next_dirent() function (this is what fixes the second problem mentioned above). PR: 270988 Reviewed by: kib MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D39775 sys/kern/vfs_subr.c | 115 ++++++++++++++++++++++++++++++------------------= ---- 1 file changed, 67 insertions(+), 48 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=